-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle dynamic import or importSync of missing module #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoov
changed the title
[WIP] Handle dynamic import or importSync of missing module
Handle dynamic import or importSync of missing module
Sep 24, 2020
ef4
requested changes
Sep 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good, if you can incorporate these two suggestions and get the tests green.
If a module is imported via `import('foo')` or `importSync('foo')` but `foo` cannot be resolved, instead create a dummy module that throws a runtime error stating that the module could not be found.
thoov
force-pushed
the
adjust-imports-missing
branch
from
September 24, 2020 22:41
aa764d9
to
0d74c8a
Compare
@ef4 this should be ready to merge |
ef4
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a module is imported via
import('foo')
orimportSync('foo')
butfoo
cannot be resolved, instead create a dummy module that throws a runtime error stating that the module could not be found. The reasoning behind this change is that it is acceptable to have "guarded imports". An example is takeember-exam
which does not explicitly depend on either ember-qunit or ember-mocha but has code like the following:During dev builds we do not strip out the conditionals that are falsy and thus when
macros-babel-plugin
runs it will try and resolve these imports (and cause a build-time error). This differs from 2 points of perspective: 1) classical system allow requiring a module that does not exist and you will not see any errors until that require is encountered at runtime (or if it is guarded it may never error). 2) The behavior of the macro system in production mode would hide the fact that this module was not found since it striped out the import branch which is different from how it would behave under dev mode.Additional background on ember-exam's change: ember-cli/ember-exam#599
Fixes: #543
Fixes: #544