Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case where peerDep is unresolvable #546

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

thoov
Copy link
Collaborator

@thoov thoov commented Sep 22, 2020

Instead of throwing an early error during the movable phase if a dependency was not found instead do nothing and let the error happen further down the line.

Fixes: #545

Instead of throwing an early error during the movable phase if a
dependency was not found instead do nothing and let the error
happen further down the line.
@thoov thoov requested a review from ef4 September 22, 2020 23:01
@ef4 ef4 merged commit a3fed70 into embroider-build:master Sep 23, 2020
@ef4
Copy link
Contributor

ef4 commented Sep 23, 2020

Thanks, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Movable package cache should tolerate missing deps
2 participants