Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce EMBROIDER_WORKING_DIRECTORY env var for concurrent builds #2285

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

simonihmig
Copy link
Collaborator

Backporting #2270 to stable.

@simonihmig simonihmig added the enhancement New feature or request label Feb 18, 2025
@simonihmig
Copy link
Collaborator Author

Failing tests seem to be a general issue on stable!?

@mansona
Copy link
Member

mansona commented Feb 19, 2025

@simonihmig yes that's true, since Ember 6.1 we can't rely on the auditing system because we now rely on exports in package.json 😞 We discussed this with @ef4 and we have a very soft "let's not change stable" since we're so close to getting the new release out, the reason being that it would be a significant effort to fix the audit system on stable

I don't know how we want to proceed on this 😞

@simonihmig
Copy link
Collaborator Author

For my understanding, what is the "auditing system"? 😅

So after having migrated hundreds of addons to v2 and Embroider compatibility, we are only now in the process to migrate production apps to "stable" Embroider + webpack. It might take us quite a while to be able to adopt Embroider/Vite (for existing apps), pending Ember upgrades but also some other roadblocks potentially (left over AMD shenanigans).

So I do expect us to be on Embroider/webpack for a while. I don't expect new development there of course, but I/we would appreciate if we could still have it in some kind of maintenance mode, to accept an occasional bug fix or land some low hanging fruits like this one.

I don't know how we want to proceed on this

If it is only for Ember 6.1+, can we limit the test matrix to only run on earlier versions?

@ef4
Copy link
Contributor

ef4 commented Feb 19, 2025

I don't think it's only a bug in the audit system. On stable, nodeResolve is used for more than just audits. It's used for resolving components for example. It's only on main where we've been able to unify all resolving through the prevailing environment.

@ef4 ef4 merged commit 3c56eda into stable Feb 19, 2025
227 checks passed
@ef4 ef4 deleted the allow-concurrent-builds-stable branch February 19, 2025 16:52
@github-actions github-actions bot mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants