Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this-property-fallback is not a possibility on ember >=4 #2185

Merged
merged 4 commits into from
Feb 19, 2025
Merged

this-property-fallback is not a possibility on ember >=4 #2185

merged 4 commits into from
Feb 19, 2025

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Nov 25, 2024

No description provided.

@ef4 ef4 changed the base branch from main to stable November 25, 2024 20:18
@ef4 ef4 added the bug Something isn't working label Feb 19, 2025
mansona
mansona approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@ef4 ef4 merged commit 2e878ac into stable Feb 19, 2025
227 checks passed
@ef4 ef4 deleted the no-this-fallback branch February 19, 2025 18:39
@github-actions github-actions bot mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balinterdi balinterdi balinterdi left review comments

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ef4 @balinterdi @mansona