Code

Eliminate node_modules rewriting#1435

Code

Merged

ef4 merged 78 commits intomainembroider-build/embroider:mainfrom done-rewrite-node-modules2embroider-build/embroider:done-rewrite-node-modules2Copy head branch name to clipboardJun 28, 2023

+3,333-3,367

Commits

Commits on May 18, 2023

• temporarily disabling new addon index resolving

  Show description for 66f15a2
  ef4

  committed
  66f15a2

  Copy full SHA for 66f15a2

• emit addon index

  ef4

  committed
  21fb865

  Copy full SHA for 21fb865

• creating RewrittenPackageCache that consumes RewrittenPackageIndex

  ef4

  committed
  0ce586e

  Copy full SHA for 0ce586e

Commits on May 19, 2023

• integrate RewrittenPackageCache with module-resolver

  ef4

  committed
  8bccbd7

  Copy full SHA for 8bccbd7

Commits on May 22, 2023

• Eliminate BuildStage

  Show description for 9425b06
  ef4

  committed
  9425b06

  Copy full SHA for 9425b06

• Simplifying compat app adapter pattern

  Show description for b21c81d
  ef4

  committed
  b21c81d

  Copy full SHA for b21c81d

• adjust the runtime require.resolves

  ef4

  committed
  b0636d0

  Copy full SHA for b0636d0

Commits on May 30, 2023

• marking private

  ef4

  committed
  25079f3

  Copy full SHA for 25079f3

Commits on Jun 2, 2023

• eliminating tiny methods that are leftover from the AppAdapter split

  ef4

  committed
  9fcca0b

  Copy full SHA for 9fcca0b

• remove redundant lint

  ef4

  committed
  d236b8e

  Copy full SHA for d236b8e

• eliminate V1DummyApp class

  ef4

  committed
  fa9e536

  Copy full SHA for fa9e536

Commits on Jun 6, 2023

• Merge branch 'main' into done-rewrite-node-modules2

  ef4

  committed
  460fc53

  Copy full SHA for 460fc53

• merging V1App into CompatApp

  ef4

  committed
  8ebb41d

  Copy full SHA for 8ebb41d

• followups to the class merge

  ef4

  committed
  a618c47

  Copy full SHA for a618c47

• more cleanup

  ef4

  committed
  f9b179e

  Copy full SHA for f9b179e

• dropping PrebuiltAddon

  Show description for e9aaad8
  ef4

  committed
  e9aaad8

  Copy full SHA for e9aaad8

• more cleanup

  ef4

  committed
  20ce08f

  Copy full SHA for 20ce08f

• simplifying macrosConfig handling

  ef4

  committed
  064a4cf

  Copy full SHA for 064a4cf

• more cleanup

  ef4

  committed
  ac58e43

  Copy full SHA for ac58e43

• fix fastboot regression

  ef4

  committed
  0915c4a

  Copy full SHA for 0915c4a

• splitting CompatAppBuilder to its own module

  ef4

  committed
  ee54e0a

  Copy full SHA for ee54e0a

Commits on Jun 7, 2023

• less state on CompatApp

  ef4

  committed
  318ef3a

  Copy full SHA for 318ef3a

Commits on Jun 8, 2023

• Merge remote-tracking branch 'upstream/main' into done-rewrite-node-modules2

  Show description for 3ae3a06
  mansona

  committed
  3ae3a06

  Copy full SHA for 3ae3a06

• remove OwningAddon custom package subclass

  mansona

  committed
  09efde9

  Copy full SHA for 09efde9

• remove seed from package-cache and set app explicitly on moveable-package-cache

  mansona

  committed
  c9010b7

  Copy full SHA for c9010b7

Commits on Jun 12, 2023

• make stage2 distinguish both views into appPackage

  ef4

  committed
  4706d1e

  Copy full SHA for 4706d1e

• stage2 explicit dummy app support

  ef4

  committed
  98c3e9e

  Copy full SHA for 98c3e9e

• fix app's nonResolvableDeps support

  ef4

  committed
  bf4d645

  Copy full SHA for bf4d645

Commits on Jun 13, 2023

• Merge branch 'main' into done-rewrite-node-modules2

  ef4

  committed
  ea4aa10

  Copy full SHA for ea4aa10

• Merge remote-tracking branch 'origin/main' into done-rewrite-node-modules2

  ef4

  committed
  6d54710

  Copy full SHA for 6d54710

• drop moved packaged cache

  Show description for 7f83c94
  ef4

  committed
  7f83c94

  Copy full SHA for 7f83c94

• resolve ember-template-compiler through module-resolver

  ef4

  committed
  5752308

  Copy full SHA for 5752308

• make rewritten-packages/index.json mandatory

  ef4

  committed
  74fc34a

  Copy full SHA for 74fc34a

Commits on Jun 14, 2023

• move rewritten package cache into shared-internals

  ef4

  committed
  eda1ab7

  Copy full SHA for eda1ab7

• using the real appRoot throughout stage3

  ef4

  committed
  8f80624

  Copy full SHA for 8f80624

• Merge remote-tracking branch 'origin/main' into done-rewrite-node-modules2

  ef4

  committed
  b953b3b

  Copy full SHA for b953b3b

• fixing a lint issue

  ef4

  committed
  e43a836

  Copy full SHA for e43a836

• adjust timing of rewritten package index generation and fix a merge typo

  ef4

  committed
  99fff1b

  Copy full SHA for 99fff1b

Commits on Jun 15, 2023

• fix another lint issue

  ef4

  committed
  503cca0

  Copy full SHA for 503cca0

• include appRoot in the identifier for the shared package caches

  mansona

  committed
  6a1a773

  Copy full SHA for 6a1a773

• add expectRewrittenAddonFilesAt utility to file-assertions

  mansona

  committed
  9805bf9

  Copy full SHA for 9805bf9

• refactor addon-styles tests to use expectRewrittenAddonFilesAt

  mansona

  committed
  490dd2d

  Copy full SHA for 490dd2d

• fix: reuse variable for newRoot in standalone addon build

  mansona

  committed
  18c3af8

  Copy full SHA for 18c3af8

• make test audits use the resolver to find the moved app package

  mansona

  committed
  c4057c9

  Copy full SHA for c4057c9

• fix lint

  mansona

  committed
  cb6fd31

  Copy full SHA for cb6fd31

• fix more expectFilesAt tests

  mansona

  committed
  402e913

  Copy full SHA for 402e913

• fix more expectFilesAt tests

  mansona

  committed
  84b881b

  Copy full SHA for 84b881b

Commits on Jun 16, 2023

• make audit assertions understand rewritten packages

  Show description for 03ee0a4
  ef4

  committed
  03ee0a4

  Copy full SHA for 03ee0a4

Commits on Jun 17, 2023

• removing accidental QUnit.only

  ef4

  committed
  7960c76

  Copy full SHA for 7960c76

• rename

  ef4

  committed
  6be2f54

  Copy full SHA for 6be2f54

• adding a backward-compat fallback

  ef4

  committed
  7ac453a

  Copy full SHA for 7ac453a

• make audit assertions support asserting about nonexist modules

  ef4

  committed
  c48f934

  Copy full SHA for c48f934

• changing expectRewrittenFiles so it can handle more complex input paths

  Show description for 1bc378e
  ef4

  committed
  1bc378e

  Copy full SHA for 1bc378e

• extraResolutions for the app

  ef4

  committed
  c5b1ae9

  Copy full SHA for c5b1ae9

• updating test Transpiling infra and making more tests pass

  ef4

  committed
  eed27a1

  Copy full SHA for eed27a1

• fix rebuilds by keeping rewritten-app apart from rewritten-addons

  ef4

  committed
  b3b6cd8

  Copy full SHA for b3b6cd8

• restoring dummy app support

  ef4

  committed
  e047151

  Copy full SHA for e047151

Commits on Jun 18, 2023

• fix isDevelopingThisPackage

  ef4

  committed
  4435a34

  Copy full SHA for 4435a34

• bugfix: using rewritten app root for v2 addon virtual peer deps

  ef4

  committed
  d10569f

  Copy full SHA for d10569f

Commits on Jun 19, 2023

• updating more tests

  ef4

  committed
  270796f

  Copy full SHA for 270796f

• updating more tests

  Show description for 89aaee8
  ef4

  committed
  89aaee8

  Copy full SHA for 89aaee8

• skipping some lts_4_4 tests due to ember-data

  ef4

  committed
  6431887

  Copy full SHA for 6431887

• unmoved packages can still resolve moved packages

  ef4

  committed
  6d8e76f

  Copy full SHA for 6d8e76f

Commits on Jun 20, 2023

• Compat adapters to deal with ember-data 4.4 undeclared dep

  Show description for 0382837
  ef4

  committed
  0382837

  Copy full SHA for 0382837

• unskip test due to ember-data compat-adapter

  ef4

  committed
  bd51bd7

  Copy full SHA for bd51bd7

• update glimmer macros to be aware of rewritten-package-cache

  ef4

  committed
  e3ba986

  Copy full SHA for e3ba986

• test setup for jest macro tests needs appPackageRoot now

  ef4

  committed
  4f02187

  Copy full SHA for 4f02187

Commits on Jun 21, 2023

• introduce explicit API for locating our (new, smaller) working dir

  ef4

  committed
  9e078f0

  Copy full SHA for 9e078f0

• cleaning up packageCache api

  ef4

  committed
  81abf21

  Copy full SHA for 81abf21

Commits on Jun 22, 2023

• bugfixes that address failures in macro-sample-addon

  ef4

  committed
  cff8d43

  Copy full SHA for cff8d43

• updating dummy app tests now that we put the working dir in the right place

  ef4

  committed
  990c5f9

  Copy full SHA for 990c5f9

• updating some more macro tests so they can find the app

  ef4

  committed
  346ad95

  Copy full SHA for 346ad95

• temporarily skip engines tests to get CI green

  mansona

  committed
  c64ae91

  Copy full SHA for c64ae91

• remove FS writing from app-differ

  mansona

  committed
  69a9516

  Copy full SHA for 69a9516

Commits on Jun 27, 2023

• implementing engine-level fastboot overrides in resolver

  ef4

  committed
  da744d9

  Copy full SHA for da744d9

• finished moving app's fastboot support into module-resolver

  ef4

  committed
  4a22433

  Copy full SHA for 4a22433

• Merge remote-tracking branch 'origin/main' into done-rewrite-node-modules2

  ef4

  committed
  d0699e2

  Copy full SHA for d0699e2

Commits on Jun 28, 2023

• replace tree-sync with a utility that only mirrors changes

  ef4

  committed
  55b592c

  Copy full SHA for 55b592c