Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use absolute path in vendor files #1245

Merged

Conversation

stevcooo
Copy link
Contributor

No description provided.

@stevcooo stevcooo force-pushed the do-not-use-absolute-path-in-vendor-files branch from 402b841 to 2ce1dcd Compare August 18, 2022 11:55
@ef4
Copy link
Contributor

ef4 commented Aug 31, 2022

A few tests need to be updated to match the new output this produces. I suspect it's as simple as changing from test() to runtimeTest() for the ones that are asserting about the config being in the output.

test() will run under both modes, runtimeTime() runs only when in run-time mode, and there's also buildTimeTest() for the opposite.

@ef4 ef4 merged commit e017581 into embroider-build:main Aug 31, 2022
@ef4
Copy link
Contributor

ef4 commented Aug 31, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants