-
Notifications
You must be signed in to change notification settings - Fork 143
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Extract owner-scoped WeakMap into service
- Loading branch information
1 parent
84ee36c
commit df53b75
Showing
4 changed files
with
56 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import Service from '@ember/service'; | ||
import { getOwner } from '@ember/application'; | ||
|
||
export default class EnsureRegisteredService extends Service { | ||
classNonces = new WeakMap(); | ||
nonceCounter = 0; | ||
|
||
register(klass, owner = getOwner(this)) { | ||
let nonce = this.classNonces.get(klass); | ||
if (nonce == null) { | ||
nonce = `-ensure${this.nonceCounter++}`; | ||
this.classNonces.set(klass, nonce); | ||
owner.register(`component:${nonce}`, klass); | ||
} | ||
return nonce; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export { default } from '@embroider/util/services/ensure-registered'; |
33 changes: 33 additions & 0 deletions
33
packages/util/tests/unit/services/ensure-registered-test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import { module, test } from 'qunit'; | ||
import { setupTest } from 'ember-qunit'; | ||
import EmberComponent from '@ember/component'; | ||
|
||
module('Unit | Service | ensure-registered', function (hooks) { | ||
setupTest(hooks); | ||
|
||
const Klass1 = EmberComponent.extend(); | ||
const Klass2 = EmberComponent.extend(); | ||
|
||
test('it returns nonce for class', function (assert) { | ||
let service = this.owner.lookup('service:-ensure-registered'); | ||
assert.equal(service.register(Klass1), '-ensure0'); | ||
}); | ||
|
||
test('it returns different nonce for different class', function (assert) { | ||
let service = this.owner.lookup('service:-ensure-registered'); | ||
assert.equal(service.register(Klass1), '-ensure0'); | ||
assert.equal(service.register(Klass2), '-ensure1'); | ||
}); | ||
|
||
test('it returns same nonce for same class', function (assert) { | ||
let service = this.owner.lookup('service:-ensure-registered'); | ||
assert.equal(service.register(Klass1), '-ensure0'); | ||
assert.equal(service.register(Klass1), '-ensure0'); | ||
}); | ||
|
||
test('it registers component', function (assert) { | ||
let service = this.owner.lookup('service:-ensure-registered'); | ||
assert.equal(service.register(Klass1), '-ensure0'); | ||
assert.ok(this.owner.hasRegistration('component:-ensure0')); | ||
}); | ||
}); |