Merge pull request #1231 from embroider-build/ignore-weird-addons

Followup to "Detect addons with customized treeForMethod names"
embroider-build · Jul 4, 2022 · 5b1f8d2 · 5b1f8d2
2 parents 28f8c99 + 68851b2
commit 5b1f8d2
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/packages/compat/src/v1-addon.ts b/packages/compat/src/v1-addon.ts
@@ -421,9 +421,14 @@ export default class V1Addon {
   }
 
   private customizesHookName(treeName: string): boolean {
+    if (!this.addonInstance.treeForMethods) {
+      // weird old addons don't even extend ember-cli's Addon base class and
+      // might not have this.
+      return false;
+    }
     for (let [name, methodName] of Object.entries(defaultMethods)) {
       if (methodName === treeName) {
-        return this.addonInstance.treeForMethods?.[name] !== methodName;
+        return this.addonInstance.treeForMethods[name] !== methodName;
       }
     }
     return false;