Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

fix: invest execution decimals and avoid empty transactions #87

Merged

Conversation

filo87
Copy link

@filo87 filo87 commented Aug 31, 2022

fixes #81

@filo87 filo87 requested a review from tibohei August 31, 2022 09:04
@filo87 filo87 self-assigned this Aug 31, 2022
@filo87 filo87 linked an issue Aug 31, 2022 that may be closed by this pull request
Copy link

@tibohei tibohei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️

@filo87 filo87 merged commit c9ae196 into main Aug 31, 2022
@filo87 filo87 deleted the 81-fix-multiple-investortransactions-with-0-value-executions branch August 31, 2022 09:08
filo87 added a commit that referenced this pull request Sep 14, 2022
* 74 index loanentity data types (#86)

* feat: create loanService

* refactor: improved service getters

* feat: increase outstandingDebt on borrowings

* feat: basics for handle loan prices

* feat: save priced loans

* feat: activate loan when priced

* feat: handle writeoffs

* feat: handle loan closed and write offs

* fix: loan.repay() should increase totalRepaid

* fix: invest execution decimals and avoid empty transactions (#87)

* 82 add prices to all investortransaction types (#88)

* chore: update chain data

* feat: extend InvestorTransaction decoration and refactor

* feat: use rpc prices from trancheTokenPrices() when investor transactions are processed (#89)

* feat: improved loans and borrower transactions (#90)

* 63 convert outflows to dai (#91)

* feat: add currency value for redeem fields

* fix: currency conversion should support null prices
filo87 added a commit that referenced this pull request Oct 26, 2022
* 74 index loanentity data types (#86)

* feat: create loanService

* refactor: improved service getters

* feat: increase outstandingDebt on borrowings

* feat: basics for handle loan prices

* feat: save priced loans

* feat: activate loan when priced

* feat: handle writeoffs

* feat: handle loan closed and write offs

* fix: loan.repay() should increase totalRepaid

* fix: invest execution decimals and avoid empty transactions (#87)

* 82 add prices to all investortransaction types (#88)

* chore: update chain data

* feat: extend InvestorTransaction decoration and refactor

* feat: use rpc prices from trancheTokenPrices() when investor transactions are processed (#89)

* feat: improved loans and borrower transactions (#90)

* 63 convert outflows to dai (#91)

* feat: add currency value for redeem fields

* fix: currency conversion should support null prices

* 98 failing poolservicegettranchetokenprices causes period to be skipped for remaining pools (#99)

* ci: fix deployment version

* fix: handle missing price updates from RPC

* fix: throw errors on missing prices

* feat: aggregate total investments and repayments for epoches (#100)

* feat: index accounts and tranche balances (#101)

* docs: add deployment status badge

* Update README.md

docs: fix badge link to deployment workflow

* feat: tracking loans history with state snapshot (#102)

* 56 handle updates to pool information poolsupdated event (#106)

* chore: upgraded packages

* feat: track pool updates

* 103 totalinvested  and totalredeemed  are missing in poolsnapshot (#107)

* fix: add missing properties to snapshot

* deploy: update node and query versions

* fix: pool investment and redemptions totals

* feat: indexing missing values (#108)

* ci: updated deployment

* ci: upgraded packages

* feat: paginated getters for snapshots and models (#109)

* chore: upgrade packages

* 104 track currency balances for accounts (#111)

* feat: add data model for currency balances

* feat: track endowments withdrawals and deposits of currency

* feat: get initial balance on currency balance init

* ci: revert subql/node version

Co-authored-by: Timon <timon@embrio.tech>
hieronx pushed a commit that referenced this pull request Dec 22, 2022
* 74 index loanentity data types (#86)

* feat: create loanService

* refactor: improved service getters

* feat: increase outstandingDebt on borrowings

* feat: basics for handle loan prices

* feat: save priced loans

* feat: activate loan when priced

* feat: handle writeoffs

* feat: handle loan closed and write offs

* fix: loan.repay() should increase totalRepaid

* fix: invest execution decimals and avoid empty transactions (#87)

* 82 add prices to all investortransaction types (#88)

* chore: update chain data

* feat: extend InvestorTransaction decoration and refactor

* feat: use rpc prices from trancheTokenPrices() when investor transactions are processed (#89)

* feat: improved loans and borrower transactions (#90)

* 63 convert outflows to dai (#91)

* feat: add currency value for redeem fields

* fix: currency conversion should support null prices

* 98 failing poolservicegettranchetokenprices causes period to be skipped for remaining pools (#99)

* ci: fix deployment version

* fix: handle missing price updates from RPC

* fix: throw errors on missing prices

* feat: aggregate total investments and repayments for epoches (#100)

* feat: index accounts and tranche balances (#101)

* docs: add deployment status badge

* Update README.md

docs: fix badge link to deployment workflow

* feat: tracking loans history with state snapshot (#102)

* 56 handle updates to pool information poolsupdated event (#106)

* chore: upgraded packages

* feat: track pool updates

* 103 totalinvested  and totalredeemed  are missing in poolsnapshot (#107)

* fix: add missing properties to snapshot

* deploy: update node and query versions

* fix: pool investment and redemptions totals

* feat: indexing missing values (#108)

* ci: updated deployment

* ci: upgraded packages

* feat: paginated getters for snapshots and models (#109)

* chore: upgrade packages

* 104 track currency balances for accounts (#111)

* feat: add data model for currency balances

* feat: track endowments withdrawals and deposits of currency

* feat: get initial balance on currency balance init

* ci: revert subql/node version

* 112 develop suitable unit testing approach (#117)

* test: fundamental approach

* test: poolHandlers testing

* test: run pools and tranche tests in CI

* test: include generation of entities

* ci: execute testing in correct order

* docs: updated data model diagram (#118)

* 115 extend kpis as from spreadsheet (#119)

* feat: aggregate loan writeoffs and total overdue

* feat: index additional data

* chore: remove unnecessary imports

* feat: parse and index loanSpecs

* fix: indexing of overdue amount

Co-authored-by: Timon <timon@embrio.tech>
hieronx pushed a commit that referenced this pull request Dec 22, 2022
* 74 index loanentity data types (#86)

* feat: create loanService

* refactor: improved service getters

* feat: increase outstandingDebt on borrowings

* feat: basics for handle loan prices

* feat: save priced loans

* feat: activate loan when priced

* feat: handle writeoffs

* feat: handle loan closed and write offs

* fix: loan.repay() should increase totalRepaid

* fix: invest execution decimals and avoid empty transactions (#87)

* 82 add prices to all investortransaction types (#88)

* chore: update chain data

* feat: extend InvestorTransaction decoration and refactor

* feat: use rpc prices from trancheTokenPrices() when investor transactions are processed (#89)

* feat: improved loans and borrower transactions (#90)

* 63 convert outflows to dai (#91)

* feat: add currency value for redeem fields

* fix: currency conversion should support null prices

* 98 failing poolservicegettranchetokenprices causes period to be skipped for remaining pools (#99)

* ci: fix deployment version

* fix: handle missing price updates from RPC

* fix: throw errors on missing prices

* feat: aggregate total investments and repayments for epoches (#100)

* feat: index accounts and tranche balances (#101)

* docs: add deployment status badge

* Update README.md

docs: fix badge link to deployment workflow

* feat: tracking loans history with state snapshot (#102)

* 56 handle updates to pool information poolsupdated event (#106)

* chore: upgraded packages

* feat: track pool updates

* 103 totalinvested  and totalredeemed  are missing in poolsnapshot (#107)

* fix: add missing properties to snapshot

* deploy: update node and query versions

* fix: pool investment and redemptions totals

* feat: indexing missing values (#108)

* ci: updated deployment

* ci: upgraded packages

* feat: paginated getters for snapshots and models (#109)

* chore: upgrade packages

* 104 track currency balances for accounts (#111)

* feat: add data model for currency balances

* feat: track endowments withdrawals and deposits of currency

* feat: get initial balance on currency balance init

* ci: revert subql/node version

* 112 develop suitable unit testing approach (#117)

* test: fundamental approach

* test: poolHandlers testing

* test: run pools and tranche tests in CI

* test: include generation of entities

* ci: execute testing in correct order

* docs: updated data model diagram (#118)

* 115 extend kpis as from spreadsheet (#119)

* feat: aggregate loan writeoffs and total overdue

* feat: index additional data

* chore: remove unnecessary imports

* feat: parse and index loanSpecs

* fix: indexing of overdue amount

* 114-Integration and fixes for new centrifuge-chain release (#133)

* 113 enhance standasdization and reusability of services (#126)

* refactor: leverage inheritance of entities

* fix: private methods

* test: extend testing for new inheritance

* test: state snapshotter (#127)

* unit testing for investortransactions and loans (#128)

* test: investor transaction tests

* test: investor transaction amounts tests

* test: loans test suite

* fix: chain release

* fix: tests

* ci: upgrade deployment versions

* ci: updated versions and parameters

* ci: use deployment defaults

* ci: disable historical data

* 132 implement naming changes [BREAKING] (#134)

* refactor: rework indexer naming

* feat!: new suffix for field resetting on new pwriod

* ci: disable flags for stati history tracking

* ci: include empty dict dor deployment command

* ci: disable historical data

* ci: update subql cli

* ci: configure project.yaml for different chains

* ci: omit historical data

* fix: reset property naming

* ci: omit historical data flag in deploy

* fix: update project.yaml

* fix: precision of currency to token amount conversion

* ci: escaping deploy.yaml

* ci: deploy.yaml escaping

* ci: more escaping

* ci: more escaping

* ci: escaping

* ci: escaping with single quotes

* ci: escaping hell

* ci: more escaping

* ci: no escaping

* ci: syntax change

* ci: new approach

* ci: test yq

* ci: test yq

* ci: updated approach

* ci: deploy version disabling history

* ci: use frozen lockfile

* chore: packages versions upgrade

* ci: use matrix deployments

* ci: fix yaml bug

* ci: refactor deployment yaml

* ci: reusable job

* ci: convert import to workflow

* ci: fix deployment type

* ci: rename to inputs

* ci: fix inputs

* ci: use npx for subQL publish version CID

* ci: use null dictionary

* ci: use empty dict

* ci: use npx overall

* ci: omit dictionary

* ci: null dict

* ci: use defaults

* ci: derive name and description from manifest

* ci: use CAPS env

* ci: indexer and query versions defined in imported workflow

* ci: add chain yamls

Co-authored-by: Timon <timon@embrio.tech>
filo87 added a commit that referenced this pull request Nov 3, 2023
* 74 index loanentity data types (#86)

* feat: create loanService

* refactor: improved service getters

* feat: increase outstandingDebt on borrowings

* feat: basics for handle loan prices

* feat: save priced loans

* feat: activate loan when priced

* feat: handle writeoffs

* feat: handle loan closed and write offs

* fix: loan.repay() should increase totalRepaid

* fix: invest execution decimals and avoid empty transactions (#87)

* 82 add prices to all investortransaction types (#88)

* chore: update chain data

* feat: extend InvestorTransaction decoration and refactor

* feat: use rpc prices from trancheTokenPrices() when investor transactions are processed (#89)

* feat: improved loans and borrower transactions (#90)

* 63 convert outflows to dai (#91)

* feat: add currency value for redeem fields

* fix: currency conversion should support null prices
filo87 added a commit that referenced this pull request Nov 3, 2023
* 74 index loanentity data types (#86)

* feat: create loanService

* refactor: improved service getters

* feat: increase outstandingDebt on borrowings

* feat: basics for handle loan prices

* feat: save priced loans

* feat: activate loan when priced

* feat: handle writeoffs

* feat: handle loan closed and write offs

* fix: loan.repay() should increase totalRepaid

* fix: invest execution decimals and avoid empty transactions (#87)

* 82 add prices to all investortransaction types (#88)

* chore: update chain data

* feat: extend InvestorTransaction decoration and refactor

* feat: use rpc prices from trancheTokenPrices() when investor transactions are processed (#89)

* feat: improved loans and borrower transactions (#90)

* 63 convert outflows to dai (#91)

* feat: add currency value for redeem fields

* fix: currency conversion should support null prices

* 98 failing poolservicegettranchetokenprices causes period to be skipped for remaining pools (#99)

* ci: fix deployment version

* fix: handle missing price updates from RPC

* fix: throw errors on missing prices

* feat: aggregate total investments and repayments for epoches (#100)

* feat: index accounts and tranche balances (#101)

* docs: add deployment status badge

* Update README.md

docs: fix badge link to deployment workflow

* feat: tracking loans history with state snapshot (#102)

* 56 handle updates to pool information poolsupdated event (#106)

* chore: upgraded packages

* feat: track pool updates

* 103 totalinvested  and totalredeemed  are missing in poolsnapshot (#107)

* fix: add missing properties to snapshot

* deploy: update node and query versions

* fix: pool investment and redemptions totals

* feat: indexing missing values (#108)

* ci: updated deployment

* ci: upgraded packages

* feat: paginated getters for snapshots and models (#109)

* chore: upgrade packages

* 104 track currency balances for accounts (#111)

* feat: add data model for currency balances

* feat: track endowments withdrawals and deposits of currency

* feat: get initial balance on currency balance init

* ci: revert subql/node version

Co-authored-by: Timon <timon@embrio.tech>
filo87 added a commit that referenced this pull request Nov 3, 2023
* 74 index loanentity data types (#86)

* feat: create loanService

* refactor: improved service getters

* feat: increase outstandingDebt on borrowings

* feat: basics for handle loan prices

* feat: save priced loans

* feat: activate loan when priced

* feat: handle writeoffs

* feat: handle loan closed and write offs

* fix: loan.repay() should increase totalRepaid

* fix: invest execution decimals and avoid empty transactions (#87)

* 82 add prices to all investortransaction types (#88)

* chore: update chain data

* feat: extend InvestorTransaction decoration and refactor

* feat: use rpc prices from trancheTokenPrices() when investor transactions are processed (#89)

* feat: improved loans and borrower transactions (#90)

* 63 convert outflows to dai (#91)

* feat: add currency value for redeem fields

* fix: currency conversion should support null prices

* 98 failing poolservicegettranchetokenprices causes period to be skipped for remaining pools (#99)

* ci: fix deployment version

* fix: handle missing price updates from RPC

* fix: throw errors on missing prices

* feat: aggregate total investments and repayments for epoches (#100)

* feat: index accounts and tranche balances (#101)

* docs: add deployment status badge

* Update README.md

docs: fix badge link to deployment workflow

* feat: tracking loans history with state snapshot (#102)

* 56 handle updates to pool information poolsupdated event (#106)

* chore: upgraded packages

* feat: track pool updates

* 103 totalinvested  and totalredeemed  are missing in poolsnapshot (#107)

* fix: add missing properties to snapshot

* deploy: update node and query versions

* fix: pool investment and redemptions totals

* feat: indexing missing values (#108)

* ci: updated deployment

* ci: upgraded packages

* feat: paginated getters for snapshots and models (#109)

* chore: upgrade packages

* 104 track currency balances for accounts (#111)

* feat: add data model for currency balances

* feat: track endowments withdrawals and deposits of currency

* feat: get initial balance on currency balance init

* ci: revert subql/node version

* 112 develop suitable unit testing approach (#117)

* test: fundamental approach

* test: poolHandlers testing

* test: run pools and tranche tests in CI

* test: include generation of entities

* ci: execute testing in correct order

* docs: updated data model diagram (#118)

* 115 extend kpis as from spreadsheet (#119)

* feat: aggregate loan writeoffs and total overdue

* feat: index additional data

* chore: remove unnecessary imports

* feat: parse and index loanSpecs

* fix: indexing of overdue amount

Co-authored-by: Timon <timon@embrio.tech>
filo87 added a commit that referenced this pull request Nov 3, 2023
* 74 index loanentity data types (#86)

* feat: create loanService

* refactor: improved service getters

* feat: increase outstandingDebt on borrowings

* feat: basics for handle loan prices

* feat: save priced loans

* feat: activate loan when priced

* feat: handle writeoffs

* feat: handle loan closed and write offs

* fix: loan.repay() should increase totalRepaid

* fix: invest execution decimals and avoid empty transactions (#87)

* 82 add prices to all investortransaction types (#88)

* chore: update chain data

* feat: extend InvestorTransaction decoration and refactor

* feat: use rpc prices from trancheTokenPrices() when investor transactions are processed (#89)

* feat: improved loans and borrower transactions (#90)

* 63 convert outflows to dai (#91)

* feat: add currency value for redeem fields

* fix: currency conversion should support null prices

* 98 failing poolservicegettranchetokenprices causes period to be skipped for remaining pools (#99)

* ci: fix deployment version

* fix: handle missing price updates from RPC

* fix: throw errors on missing prices

* feat: aggregate total investments and repayments for epoches (#100)

* feat: index accounts and tranche balances (#101)

* docs: add deployment status badge

* Update README.md

docs: fix badge link to deployment workflow

* feat: tracking loans history with state snapshot (#102)

* 56 handle updates to pool information poolsupdated event (#106)

* chore: upgraded packages

* feat: track pool updates

* 103 totalinvested  and totalredeemed  are missing in poolsnapshot (#107)

* fix: add missing properties to snapshot

* deploy: update node and query versions

* fix: pool investment and redemptions totals

* feat: indexing missing values (#108)

* ci: updated deployment

* ci: upgraded packages

* feat: paginated getters for snapshots and models (#109)

* chore: upgrade packages

* 104 track currency balances for accounts (#111)

* feat: add data model for currency balances

* feat: track endowments withdrawals and deposits of currency

* feat: get initial balance on currency balance init

* ci: revert subql/node version

* 112 develop suitable unit testing approach (#117)

* test: fundamental approach

* test: poolHandlers testing

* test: run pools and tranche tests in CI

* test: include generation of entities

* ci: execute testing in correct order

* docs: updated data model diagram (#118)

* 115 extend kpis as from spreadsheet (#119)

* feat: aggregate loan writeoffs and total overdue

* feat: index additional data

* chore: remove unnecessary imports

* feat: parse and index loanSpecs

* fix: indexing of overdue amount

* 114-Integration and fixes for new centrifuge-chain release (#133)

* 113 enhance standasdization and reusability of services (#126)

* refactor: leverage inheritance of entities

* fix: private methods

* test: extend testing for new inheritance

* test: state snapshotter (#127)

* unit testing for investortransactions and loans (#128)

* test: investor transaction tests

* test: investor transaction amounts tests

* test: loans test suite

* fix: chain release

* fix: tests

* ci: upgrade deployment versions

* ci: updated versions and parameters

* ci: use deployment defaults

* ci: disable historical data

* 132 implement naming changes [BREAKING] (#134)

* refactor: rework indexer naming

* feat!: new suffix for field resetting on new pwriod

* ci: disable flags for stati history tracking

* ci: include empty dict dor deployment command

* ci: disable historical data

* ci: update subql cli

* ci: configure project.yaml for different chains

* ci: omit historical data

* fix: reset property naming

* ci: omit historical data flag in deploy

* fix: update project.yaml

* fix: precision of currency to token amount conversion

* ci: escaping deploy.yaml

* ci: deploy.yaml escaping

* ci: more escaping

* ci: more escaping

* ci: escaping

* ci: escaping with single quotes

* ci: escaping hell

* ci: more escaping

* ci: no escaping

* ci: syntax change

* ci: new approach

* ci: test yq

* ci: test yq

* ci: updated approach

* ci: deploy version disabling history

* ci: use frozen lockfile

* chore: packages versions upgrade

* ci: use matrix deployments

* ci: fix yaml bug

* ci: refactor deployment yaml

* ci: reusable job

* ci: convert import to workflow

* ci: fix deployment type

* ci: rename to inputs

* ci: fix inputs

* ci: use npx for subQL publish version CID

* ci: use null dictionary

* ci: use empty dict

* ci: use npx overall

* ci: omit dictionary

* ci: null dict

* ci: use defaults

* ci: derive name and description from manifest

* ci: use CAPS env

* ci: indexer and query versions defined in imported workflow

* ci: add chain yamls

Co-authored-by: Timon <timon@embrio.tech>
filo87 pushed a commit that referenced this pull request Dec 21, 2023
* feat: set up mainnet

* fix: mainnet evm config
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix multiple investorTransactions with 0 value executions
2 participants