URLSessionDelegateProxy self recursion crash #171
Closed
+34
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prevent self-delegation added similar check for the session delegate: !(sessionDelegate is URLSessionDelegateProxy) combined the guard conditions to make the code more robust
Dependency ReviewThe following issues were found:
License IssuesPackage.resolved
OpenSSF Scorecard
Scanned Files
|
Generated by 🚫 Danger Swift against 8509880 |
ArielDemarco
reviewed
Feb 4, 2025
| @@ -88,13 +90,10 @@ class URLSessionDelegateProxy: NSObject { | |||
| } | |||
|
|
|||
| // if session delegate also responds to selector, we must call it | |||
| if let sessionDelegate = session.delegate, | |||
| sessionDelegate.responds(to: selector) { | |||
There was a problem hiding this comment.
I wouldn't remove this line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puttshack team experiencing a hang/crash noticed in URLSessionDelegateProxy
added checks using !(originalDelegate is URLSessionDelegateProxy) to prevent self-delegation
added similar check for the session delegate: !(sessionDelegate is URLSessionDelegateProxy)
combined the guard conditions to make the code more robust