Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

blog(embertimes87): Classic Class Owner Tunnel #3847

Merged
merged 2 commits into from
Mar 1, 2019
Merged

blog(embertimes87): Classic Class Owner Tunnel #3847

merged 2 commits into from
Mar 1, 2019

Conversation

chrisrng
Copy link
Contributor

@chrisrng chrisrng commented Mar 1, 2019

Added my name in an earlier (open) PR

@locks locks temporarily deployed to ember-website-staging-pr-3847 March 1, 2019 15:04 Inactive
amyrlam
amyrlam approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i really appreciate the extra writeup! 🎉

and thanks for making the merge conflicts easier, it often gets overloaded late thurs/fri 😅

@amyrlam amyrlam merged commit 66e46d6 into blog/embertimes-87 Mar 1, 2019
@chrisrng chrisrng deleted the chrisrng-patch-2 branch March 1, 2019 18:07
@chrisrng
Copy link
Contributor Author

chrisrng commented Mar 1, 2019

i really appreciate the extra writeup! 🎉

and thanks for making the merge conflicts easier, it often gets overloaded late thurs/fri 😅

@amyrlam I got ya'll haha thanks for reviewing too! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyrlam amyrlam amyrlam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisrng @amyrlam @locks