rfc: ember-data | Modernize PromiseManyArray #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@runspired looks great! |
19 tasks
30 tasks
25 tasks
Samsinite
reviewed
Dec 14, 2021
text/0745-ember-data-deprecate-methods-on-promise-many-array.md
Outdated
Show resolved
Hide resolved
luxzeitlos
reviewed
Jan 17, 2022
Co-authored-by: Sam Clopton <samsinite@gmail.com>
|
Looks like this at least needs to be updated to target something post 4.x |
|
@wagenet it was created to target 5.0 from the beginning :) |
|
Oops, I misread it. |
text/0745-ember-data-deprecate-methods-on-promise-many-array.md
Outdated
Show resolved
Hide resolved
Co-authored-by: MrChocolatine <47531779+MrChocolatine@users.noreply.github.com>
runspired
added a commit
to emberjs/data
that referenced
this pull request
Aug 5, 2022
runspired
added a commit
to emberjs/data
that referenced
this pull request
Aug 9, 2022
* ill follow you into the dark * more sanity * fix imports * get tests passing * replace usage of internalModel.isHiddenFromRecordArrays * begin move of deleteRecord logic into the store * trim trim trim * even more trim * still a lot to do, but starting to take shape * the shape of things * fix most tests, 44 to go * 71 test failures to go, implemente PromiseManyArray deprecation from RFC emberjs/rfcs#745 * add better debugging capabilities * cleanup * further rationalization * logging improvements * progress * down to 36 failed tests * down to 17 failed tests * cleanup * All the cleanup * fix lint * all the main tests fixed * bump some deps * make nice for deprecation stripping * some minor cleanup * fix some scenarios * fix lock * fix node14
This was referenced Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered Full Text