Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Medium Term Plan #452

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Conversation

igorT
Copy link
Member

@igorT igorT commented Feb 21, 2019

@mikkopaderes
Copy link

Not trying to be rude or anything and maybe it's just me not being able to fully absorb everything in this RFC. ✌️

Basically, my take is shouldn't the community just be concerned with the public APIs that'll be exposed to us? I feel the core team should be the one to decide how they want to design and structure their code base so long as they commit to the promised APIs and not break existing ones. There would be less overhead for the community to take in the RFC details and will let you guys (and other community members) to just dev immediately without waiting for our feedback.

@pete-the-pete
Copy link

Sounds good, and thanks for the diagrams!

The list of RFCs looks like a commitment to some ideas, which sounds good, but what does that mean for other RFCs? Can some be closed? Will others be folded in?

@runspired runspired added the T-ember-data RFCs that impact the ember-data library label Feb 22, 2019
@runspired runspired changed the title Ember Data Medium Term Plan RFC [Data] Medium Term Plan RFC Mar 7, 2019
@runspired runspired changed the title [Data] Medium Term Plan RFC [Data] Medium Term Plan Mar 7, 2019
@igorT
Copy link
Member Author

igorT commented Jun 26, 2019

@mikkopaderes Your perspective makes a lot of sense, and I think in general internal refactors usually don't go through an RFC process. However given the size of the change, and the long term nature of the work, we felt that it made sense to have a place to lay out the plan and propose and debate the direction and align the contributors.. While not perfect, an RFC made sense for that.

@igorT
Copy link
Member Author

igorT commented Jun 26, 2019

@pete-the-pete Great point. This RFC spawned several new ones, and with regards to existing ones, we are going through them and addressing them, though most of them aren't impacted by these specific changes, other than the fact it should be easier to implement some of the RFC functionality in addons as opposed to ED core

@igorT igorT force-pushed the igor/ember-data-medium-plan branch from d1b0b76 to 0fa5b40 Compare June 26, 2019 20:51
@igorT igorT force-pushed the igor/ember-data-medium-plan branch from ff3c381 to 4171b99 Compare June 26, 2019 20:55
@igorT igorT merged commit f982f76 into emberjs:master Jun 26, 2019
@igorT igorT deleted the igor/ember-data-medium-plan branch June 26, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final Comment Period T-ember-data RFCs that impact the ember-data library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants