[Bug]: set symbol on factory objects only in Prod for sealed objects #19470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
commented
Mar 19, 2021
9a3b03b to
4151d39
Compare
rwjblue
reviewed
Mar 20, 2021
rwjblue
reviewed
Mar 20, 2021
pzuraq
approved these changes
Mar 20, 2021
rwjblue
reviewed
Mar 20, 2021
Comment on lines
579
to
578
| if (DEBUG) { | ||
| // Eagerly add INIT_FACTORY to avoid issues in DEBUG as a result of Object.seal(mixin) | ||
| this[INIT_FACTORY] = null; | ||
| } | ||
|
|
||
| if (DEBUG) { |
There was a problem hiding this comment.
Sorry @snewcomer for the run around here, would you mind merging these two if (DEBUG) { statements? They are back to back, and it looks a bit odd...
There was a problem hiding this comment.
I clearly don't have my thinking hat on today. Fixed!
rwjblue
approved these changes
Mar 21, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref emberjs/data#7435
ember.js/packages/@ember/-internals/metal/lib/mixin.ts
Line 589 in 725cdf2