-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation for Route#disconnectOutlet
#19407
Add deprecation for Route#disconnectOutlet
#19407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, I think we should handle the types for expectDeprecation
a bit differently, but other than that this is great!
@@ -4,6 +4,8 @@ import { | |||
moduleFor, | |||
strip, | |||
} from 'internal-test-helpers'; | |||
import { ExpectDeprecationFunc } from '../../../../../../internal-test-helpers/lib/ember-dev/deprecation'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should likely be added to the above imports from internal-test-helpers
, and the ExpectDeprecationFunc
type/interface should be exported from that package
packages/@ember/-internals/glimmer/tests/integration/application/debug-render-tree-test.ts
Outdated
Show resolved
Hide resolved
f9da995
to
a7f16ce
Compare
96a8a34
to
a34856e
Compare
a34856e
to
33979b8
Compare
@rwjblue I've resolved the conflict 🙇♂️ |
Thank you @patocallaghan! |
Adds deprecation for
Route#disconnectOutlet
. See RFC 491 for more info.I was initially going to ship the
disconnectOutlet
,render
andrenderTemplate
deprecations together in #19388 but the amount of tests which break and require aexpectDeprecation
is a bit overwhelming and taking longer than expected 😅 I've decided to break this one out instead.