Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[BUGFIX lts] Prevents infinite rerenders when errors occur during render" #19225

Merged

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Oct 23, 2020

Reverts #19200 as it caused some production test failures:

[1022/210630.114228:INFO:CONSOLE(52)] "    Failed assertion: Died on test #5     at generateTest (http://localhost:13141/tests/ember-tests.js:108736:15)
    at Set.forEach (<anonymous>)
    at setupTestClass (http://localhost:13141/tests/ember-tests.js:108722:16)
    at http://localhost:13141/tests/ember-tests.js:108669:22
    at Object.<anonymous> (http://localhost:13141/tests/ember-tests.js:108073:9)
    at processModule (http://localhost:13141/tests/qunit/qunit.js:1200:16)
    at module$1 (http://localhost:13141/tests/qunit/qunit.js:1225:4)
    at Object.QUnit.module (http://localhost:13141/tests/ember-tests.js:108065:14): Cannot read property 'firstNode' of null
TypeError: Cannot read property 'firstNode' of null
    at SimpleLiveBlock.firstNode (http://localhost:13141/tests/ember.js:49238:20)
    at UpdatableBlockImpl.firstNode (http://localhost:13141/tests/ember.js:49238:20)
    at clear (http://localhost:13141/tests/ember.js:48106:24)
    at UpdatableBlockImpl.reset (http://localhost:13141/tests/ember.js:49339:25)
    at Function.resume (http://localhost:13141/tests/ember.js:48941:31)
    at TryOpcode.handleException (http://localhost:13141/tests/ember.js:52983:44)
    at UpdatingVMFrame.handleException (http://localhost:13141/tests/ember.js:53228:31)
    at UpdatingVM._throw [as throw] (http://localhost:13141/tests/ember.js:52893:18)
    at Assert.evaluate (http://localhost:13141/tests/ember.js:50235:17)
    at UpdatingVM._execute (http://localhost:13141/tests/ember.js:52880:16)", source:  (52)
[1022/210630.114975:INFO:CONSOLE(52)] "    Failed assertion: afterEach failed on  it can recover resets the transaction when an error is thrown during rerender: Cannot read property 'firstNode' of null
TypeError: Cannot read property 'firstNode' of null
    at SimpleLiveBlock.firstNode (http://localhost:13141/tests/ember.js:49238:20)
    at UpdatableBlockImpl.firstNode (http://localhost:13141/tests/ember.js:49238:20)
    at SimpleLiveBlock.firstNode (http://localhost:13141/tests/ember.js:49238:20)
    at UpdatableBlockImpl.firstNode (http://localhost:13141/tests/ember.js:49238:20)
    at SimpleLiveBlock.firstNode (http://localhost:13141/tests/ember.js:49238:20)
    at clear (http://localhost:13141/tests/ember.js:48106:24)
    at http://localhost:13141/tests/ember.js:53245:16
    at invoke (http://localhost:13141/tests/ember.js:57176:16)
    at Queue.flush (http://localhost:13141/tests/ember.js:57066:13)
    at DeferredActionQueues.flush (http://localhost:13141/tests/ember.js:57273:21)", source:  (52)

It seems likely that this was caused by interactions between #19199 and #19200, but I have not dug into it.

@rwjblue rwjblue requested a review from pzuraq October 23, 2020 17:20
@rwjblue rwjblue merged commit 5ec738c into master Oct 23, 2020
@rwjblue rwjblue deleted the revert-19200-bugfix/prevent-infinite-rerenders-on-error branch October 23, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant