Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] add template name to debug render tree #18548

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Conversation

chancancode
Copy link
Member

I'm not sure if this should be [BUGFIX beta] or [BUGFIX release]?

@@ -286,15 +298,16 @@ if (ENV._DEBUG_RENDER_TREE) {
this.register(
'template:application',
compile(strip`
{{outlet}}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out this is not valid: #18547

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let’s call it BUGFIX release..

@rwjblue
Copy link
Member

rwjblue commented Nov 15, 2019

CI failure is due to linting:


yarn run v1.19.1
277$ yarn lint:tsc && yarn lint:tslint && yarn lint:eslint && yarn lint:docs
278$ tsc --noEmit
279packages/@ember/-internals/glimmer/lib/component-managers/input.ts(10,1): error TS6133: 'templateName' is declared but its value is never read.
280packages/@ember/-internals/glimmer/lib/component-managers/input.ts(10,10): error TS2305: Module '"../template"' has no exported member 'name'.
281packages/@ember/-internals/glimmer/lib/component-managers/root.ts(17,1): error TS6133: 'template' is declared but its value is never read.

@chancancode chancancode merged commit 4232a4b into master Nov 15, 2019
@chancancode chancancode deleted the debug-template branch November 15, 2019 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants