-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX beta] improve fn
& on
undefined callback message
#18353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally seems good, I think that CI is failing due to some testing the exact assertion message. Also, in a recent PR @chancancode added a ref.debug
method that we might be able to leverage here instead of manually digging into callbackRef.propertyKey.
Hi, I was still not quite happy with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a description of what information this adds to the debug output? It seems to be serializing the full debug stack and adding it to any errors that occur, it'd be useful to see an example of what the output looks like to determine how helpful it would be
packages/@ember/-internals/glimmer/tests/integration/helpers/fn-test.js
Outdated
Show resolved
Hide resolved
@chancancode would mind taking a look at this one also? It seems related to recent work that you've done... |
Hi, the description will look like this:
unfortunately it doesnt work for modifiers |
An update recently landed (in #18372) to add a new type of render debug support (this was needed for supporting custom component types in the ember-inspector), I'd be interested to see if you can take a look at that work and leverage it for some of the plumbing here. |
Looks great to me, would you mind squashing the commits down to one and prefixing it with |
fn
& on
undefined callback message
🙏Bitten by this often migrating to new syntaxes in octane. Any update @rwjblue ? |
Thanks again @patricklx! |
This is a godsend. Thank you for this 🙏 |
include parent and property key in the message