Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] adjust assertion to allow for either undefined or null #16494

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

Dhaulagiri
Copy link
Contributor

#16485, but targeted against master

@rwjblue rwjblue merged commit 9bac05c into emberjs:master Apr 11, 2018
@rwjblue
Copy link
Member

rwjblue commented Apr 11, 2018

Thank you!

@rwjblue
Copy link
Member

rwjblue commented Apr 11, 2018

I've pulled these changes into the beta and release branches, you should be able to use the latest release / beta builds once CI is completed and the changes should be included in the next release of each branch...

@Dhaulagiri Dhaulagiri deleted the br-value branch April 11, 2018 21:33
@Dhaulagiri
Copy link
Contributor Author

Dhaulagiri commented Apr 11, 2018

you should be able to use the latest release / beta builds

@rwjblue is there a good place to find these or can we point package.json at 'emberjs/ember.js#release'?

@rwjblue
Copy link
Member

rwjblue commented Apr 11, 2018

Turns out that I didn't have a good way to explain this, so I just made it simpler (in ember-cli/ember-source-channel-url#2).

This should be all you need to do to get the URL to put in your package.json:

npm install -g ember-source-channel-url
ember-source-channel-url release

That will print out the current URL for that channel, and you can put that directly in your package.json like:

//...snip...
"ember-source": "<URL GOES HERE>",
//...snip...

@Dhaulagiri
Copy link
Contributor Author

Nice! I’ll try to see if there is a way to better document this in the ember repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants