[BUGFIX beta] Throw if Ember is in both package.json and bower.json.
#15582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warning was non-obvious (which one "wins"?), and allows for misconfiguration in `config/ember-try.js` to _seem_ like you are testing many Ember versions but in reality you are just testing whatever `ember-source` version you have 😭.
003733c to
f58d176
Compare
|
this sounds like it has implications for |
|
Ya, good point @Turbo87 we should fix that... |
|
@rwjblue Should this be closed or is there something we can salvage? |
|
No, now that bower is not a viable option we don’t need this any longer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning was non-obvious (which one "wins"?), and allows for misconfiguration in
config/ember-try.jsto seem like you are testing many Ember versions but in reality you are just testing whateverember-sourceversion you have 😭.See emberjs/data#5123 for the full sob story...