Bump glimmer-vm packages to 0.24. #15245

chancancode · 2017-05-17T03:37:29Z

ESLint (http://localhost:5200/tests/index.html?package=ember-glimmer&filter=ESLint)
Static Content (http://localhost:5200/tests/index.html?package=ember-glimmer&filter=static%20content)
Dynamic Content (http://localhost:5200/tests/index.html?package=ember-glimmer&filter=dynamic%20content)
Syntax (http://localhost:5200/tests/index.html?package=ember-glimmer&filter=syntax)
Helpers (http://localhost:5200/tests/index.html?hidepassed&package=ember-glimmer&filter=helpers)
Components (http://localhost:5200/tests/index.html?package=ember-glimmer&filter=Components%20test&hidepassed)
- this.attrs, positional arguments
  - We broke this in d979a63
- Cascading failures (cannot reuse the same DIV, cannot start nested transactions, etc)
- contextual components (http://localhost:7200/tests/index.html?hidepassed&filter=contextual)
- local lookup (http://localhost:7200/tests/index.html?hidepassed&filter=local)
Iterable (http://localhost:5200/tests/index.html?package=ember-glimmer&module=Iterable)
- Remove? (Add unit tests for ember-glimmer/utils/iterable #14763 (comment))
...

This will break a lot of things but is a good excuse to rethink the "process args" code.

homu · 2017-05-17T19:51:16Z

☔ The latest upstream changes (presumably #15247) made this pull request unmergeable. Please resolve the merge conflicts.

homu · 2017-05-23T00:05:22Z

☔ The latest upstream changes (presumably #15254) made this pull request unmergeable. Please resolve the merge conflicts.

This is only needed when a catastrophic failure happens that prevents the normal removal from working. Doing this in the teardown greatly reduces the number of invalid faulures when errors occur during rendering.

These are largely duplication functionality in `{{each-in}}`'s own tests. They were added as a way to flesh out the iterable implementation.

knownasilya · 2017-05-23T16:01:46Z

Interesting seeing the dog fooding of component-managers and how they are used. Good stuff and much to learn.

…PathReference` API.

Fixes a few node tests.

rwjblue · 2017-05-24T16:27:08Z

Did some quick asset size checks, and the min + gz size is slightly better (current master 120.54 KB; after this PR 120.15 KB).

rwjblue · 2017-05-26T20:56:58Z

I did some general benchmarking (against the emberaddons.com app), and it seems that we haven't introduced a regression here.

Seems good to ship...

knownasilya · 2017-05-27T02:29:28Z

rwjblue · 2017-05-27T16:56:23Z

Did another test against emberobserver.com (which has a larger rendering phase):

chadhietala · 2017-05-27T21:10:10Z

packages/ember-glimmer/lib/component-managers/outlet.js

+    }
+  }
+
+  didCreateElement() {}


Can't these go on the abstract manager?

chadhietala · 2017-05-27T21:10:36Z

packages/ember-glimmer/lib/component-managers/render.js

+    return null;
+  }
+
+  didCreateElement() {}


Same comment about putting them on the abstract manager.

Yep, totally agreed.

chadhietala · 2017-05-28T17:17:40Z

LGTM

knownasilya · 2017-05-29T17:49:43Z

Woop

chancancode added 13 commits May 16, 2017 19:38

Bump Glimmer version

993abfb

Fix build scripts for latest Glimmer

10a2e8b

These are built-in now

a574dee

Fix macro syntax

a7fbb70

Update helpers to use new args

6d1983c

✂️ symbolTable part 1

99ac470

Fix iterable hook

1931603

Fix compilation

7467fa2

✂️ getArgs

7160af0

Fix macros

60e62a7

Fix closure component helper

9921db3

[WIP] Fix component args

d979a63

This will break a lot of things but is a good excuse to rethink the "process args" code.

Fix {{hash}}

17f5990

rwjblue added 3 commits May 18, 2017 17:22

Merge branch 'master' into bump-glimmer

01e8fde

Fix {{mut}}.

68bbd91

Fix (action.

d44b7d1

rwjblue force-pushed the bump-glimmer branch from 009193d to d44b7d1 Compare May 19, 2017 01:56

rwjblue added 2 commits May 18, 2017 22:14

Fix {{action.

aeed4af

Fix non-singleton {{render tests.

d3f6ffa

rwjblue added 4 commits May 22, 2017 21:35

Ensure managers return null from prepareArgs to "pass through".

56da213

Make test helpers clear up renderers upon teardown.

887cd9e

This is only needed when a catastrophic failure happens that prevents the normal removal from working. Doing this in the teardown greatly reduces the number of invalid faulures when errors occur during rendering.

fixup! Fix non-singleton {{render tests.

7a20aa2

Initial pass at supporting "rest arg" style positionals.

8f8559f

rwjblue mentioned this pull request May 23, 2017

Ensure hasDefault and hasInverse function properly. glimmerjs/glimmer-vm#500

Merged

Remove iterableForObject tests.

3da5219

These are largely duplication functionality in `{{each-in}}`'s own tests. They were added as a way to flesh out the iterable implementation.

rwjblue mentioned this pull request May 23, 2017

Add unit tests for ember-glimmer/utils/iterable #14763

Merged

rwjblue added 2 commits May 23, 2017 09:27

Update glimmer versions to 0.24.0-alpha.2.

2f5f544

Merge remote-tracking branch 'origin/master' into bump-glimmer

23b0d10

Split component managers out from syntax definition.

479941a

rwjblue added 4 commits May 23, 2017 13:05

Fix closure component currying and positional param munging.

877dfa9

Fixup layout caching tests.

86fcd7c

Fix issues with AST transform for {{this.attrs.foo}} -> {{@foo}}.

3747924

Bump glimmer-vm packages to 0.24.0-beta.1.

2c89920

rwjblue changed the title ~~[WIP] Bump glimmer~~ Bump glimmer-vm packages to 0.24. May 23, 2017

rwjblue added 5 commits May 23, 2017 16:21

Ensure that newly created PositionalArgumentsReference implements `…

a76889e

…PathReference` API.

Fix ember-engines-mount-params feature with glimmer-vm@0.24.

b519467

Update to glimmer-vm 0.24.0-beta.2.

4461804

Fix glimmer-custom-component-manager feature for glimmer-vm 0.24.x.

3abb295

Bump glimmer-vm packages to 0.24.0-beta.3.

fab7a33

Fixes a few node tests.

rwjblue added 2 commits May 26, 2017 15:42

Merge remote-tracking branch 'origin/master' into bump-glimmer

8ad80ce

Bump glimmer-vm packages to 0.24.0-beta.4

b584963

chadhietala reviewed May 27, 2017

View reviewed changes

Migrate default component manager hooks to abstract base class.

33391a8

rwjblue merged commit 91d8f08 into master May 29, 2017

locks deleted the bump-glimmer branch July 18, 2017 08:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump glimmer-vm packages to 0.24. #15245

Bump glimmer-vm packages to 0.24. #15245

chancancode commented May 17, 2017 •

edited by rwjblue

Loading

homu commented May 17, 2017

homu commented May 23, 2017

knownasilya commented May 23, 2017

rwjblue commented May 24, 2017 •

edited

Loading

rwjblue commented May 26, 2017

knownasilya commented May 27, 2017

rwjblue commented May 27, 2017

chadhietala May 27, 2017

chadhietala May 27, 2017

rwjblue May 27, 2017

chadhietala commented May 28, 2017

knownasilya commented May 29, 2017

Bump glimmer-vm packages to 0.24. #15245

Bump glimmer-vm packages to 0.24. #15245

Conversation

chancancode commented May 17, 2017 • edited by rwjblue Loading

homu commented May 17, 2017

homu commented May 23, 2017

knownasilya commented May 23, 2017

rwjblue commented May 24, 2017 • edited Loading

rwjblue commented May 26, 2017

knownasilya commented May 27, 2017

rwjblue commented May 27, 2017

chadhietala May 27, 2017

Choose a reason for hiding this comment

chadhietala May 27, 2017

Choose a reason for hiding this comment

rwjblue May 27, 2017

Choose a reason for hiding this comment

chadhietala commented May 28, 2017

knownasilya commented May 29, 2017

chancancode commented May 17, 2017 •

edited by rwjblue

Loading

rwjblue commented May 24, 2017 •

edited

Loading