improve doc for filter CP #14605
improve doc for filter CP #14605
Conversation
|
@rwjblue amended |
| @@ -278,6 +278,28 @@ export function mapBy(dependentKey, propertyKey) { | |||
| hamster.get('remainingChores'); // [{name: 'write more unit tests', done: false}] | |||
| ``` | |||
|
|
|||
| You can also use `@each` in your dependent key, the callback will still use the underlying array: | |||
There was a problem hiding this comment.
🤔 I'm a bit concerned people will hurriedly read and start using chores.@each (for example) without the leaf property. Maybe @each.property? Maybe it's not a concern.
|
@locks right, amended |
| { name: 'write more unit tests', done: true } | ||
| ] | ||
| }); | ||
| hamster.set('done', false); |
There was a problem hiding this comment.
What is this setting? should the example be to set the last item of chores as done: false? or perhaps just remove the set example and define one of the chores to have done: false in the call to Hamster.create
|
@Leooo hi, if you need help addressing @pixelhandler's comments let us know! Let's get this merged :D |
|
@locks didn't see @pixelhandler 's comment, on it thanks |
|
@locks @pixelhandler better? I tested the last example, thanks for spotting the issue |
| ]) | ||
| }); | ||
| hamster.get('remainingChores'); // [{name: 'write more unit tests', done: false}] | ||
| hamster.get('chores')[2].set('done', true); |
There was a problem hiding this comment.
Maybe change this for hamster.get('chores').objectAt(2).set('done', true);?
|
@Leooo thank you for your work! :) Can you squash the commits for us, and I'll get rwjblue to re-review your PR? |
|
Thank you! |
Was really not obvious to me before that the
dependentKeyfor afilterCP could be anything different than the array used to filter.