[CLEANUP beta] Removed deprecated currentWhen of LinkComponent

[cibernox]

Use current-when instead

[cibernox]

Note: I removed this lines, I haven't see the need to duplicate the same attribute under two different keys, both in this.attrs and under the object itself (and with different casing).

[rwjblue]

This is a breaking change without deprecation as it exists here.

Consider the following usage:

{{link-to 'stuff' 'stuff' current-when='foo'}}

In the above invocation, attrs['current-when'] was previously setting currentWhen so that you could call this.get('currentWhen') (instead of this.get('current-when')). We could add a deprecatingAlias from currentWhen to current-when if we need to...

[cibernox]

I considered that, but since the currentWhen attribute was deprecated explicitly set and was marked as private in the docs I wasn't sure if I had to go through the intermediate step. Do I?

[cibernox]

ping on this?

[mixonic]

@cibernox even changing private APIs we like to do a check to see if there is usage in the wild.

Unfortunately it seems like there is plenty: https://github.com/search?q=currentWhen&type=Code&utf8=%E2%9C%93 so we should add a corresponding deprecation in 1.13 :-/

[btecu]

current-when sounds so helpful and I had no idea this existed.

[cibernox]

Rebased after deprecated code got one of those fancy deprecation ids.

[mixonic]

@rwjblue please confirm that the deprecation the removes should have been until: 2.0.0? I think we need to change a few of them.

[rwjblue]

I kinda thought we'd keep this around until 3.0.0 (hence the until value). It doesn't cost us much to have, and the deprecation was added pretty late in the 1.13.x stable period.

Gonna close this for now. Others please feel free to argue with me 😺

[btecu]

Unrelated, but any chance we could make current-when public?
It would be very useful when pagination or sorting are present.

[mixonic]

@btecu it should be public afaik. If it is marked otherwise a PR is definitely welcome.