Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to build ember from master #17678

Closed
dbrusilovsky opened this issue Feb 27, 2019 · 9 comments
Closed

Unable to build ember from master #17678

dbrusilovsky opened this issue Feb 27, 2019 · 9 comments

Comments

@dbrusilovsky
Copy link
Contributor

dbrusilovsky commented Feb 27, 2019 •
edited
Loading

I'm trying to build ember using yarn install and yarn build, and am running into the following error:

Build Error (broccoli-persistent-filter:Babel) in @ember/-internals/browser-environment.js
​
Cannot read property 'getHash' of null

A paste of my process:
https://dpaste.de/Ne8h

Node version: v10.15.0
Yarn version: v1.13.0
Operating system: macos 10.14.3

The issue was replicated on another machine by @efx on discord.
@dbrusilovsky
Copy link
Contributor Author

Error log: https://dpaste.de/j3ZU

@dbrusilovsky
Copy link
Contributor Author

Offending commit appears to be e90aee2

mixonic added a commit to mixonic/ember.js that referenced this issue Feb 28, 2019
@mixonic
Revert upgrade to hash-for-dep 1.4.7
d8cef0d 
Fixes the build as reported in
emberjs#17678
@mixonic mixonic mentioned this issue Feb 28, 2019
Merged
@mixonic
Copy link
Member

mixonic commented Feb 28, 2019

@rwjblue @stefanpenner I ran into this as well tonight, seems related to the bump of hash-for-dep from 1.2.3 to 1.4.7. I opened a hacky quick fix for Ember in #17679.

@rwjblue
Copy link
Member

rwjblue commented Feb 28, 2019

Thanks for reporting! Will dig in to see what’s going on...

@stefanpenner
Copy link
Member

stefanpenner commented Feb 28, 2019 •
edited by mixonic
Loading

I have an idea what the issue is. And with the reproduction it should be easy to tackle.

@ppcano
Copy link
Contributor

ppcano commented Mar 2, 2019

I don't know if this is related but when using my local ember-source repo with an Octane app, an exception is thrown:

Directory not found: /Users/ppcano/dev/ember/ember.js/dist/legacy

Steps:

cd ember.js
yarn link
yarn start

// other terminal
ember new oct-app -b ember-octane-app-blueprint --yarn
cd oct-app
yarn link ember-source
ember s -p 4201

@pzuraq
Copy link
Contributor

pzuraq commented Mar 2, 2019

@ppcano You need to run yarn start --environment="production", your app is targeting legacy browsers (IE11, etc) and looking for the legacy build, which is only built in production mode in the ember-source repo

stefanpenner added a commit to stefanpenner/hash-for-dep that referenced this issue Mar 2, 2019
@stefanpenner
[BUGFIX] restore old behavior – hashing garbage input should not error
dd0192e 
hashForDep with invalid input, would not error rather would produce a checksum. So restoring this for now, although we should remove in the next major version.

One deviation from the old behavior is to ensure the all garbage input doesn’t produce the same hash, rather it will get a hash based on inputs provided.

Context:

* emberjs/ember.js#17679
* emberjs/ember.js#17678
@stefanpenner
Copy link
Member

@ppcano that doesn't seem related

@stefanpenner stefanpenner mentioned this issue Mar 2, 2019
Merged
stefanpenner added a commit to stefanpenner/hash-for-dep that referenced this issue Mar 2, 2019
@stefanpenner
[BUGFIX] restore old behavior – hashing garbage input should not error
c80d728 
hashForDep with invalid input, would not error rather would produce a checksum. So restoring this for now, although we should remove in the next major version.

One deviation from the old behavior is to ensure the all garbage input doesn’t produce the same hash, rather it will get a hash based on inputs provided.

Context:

* emberjs/ember.js#17679
* emberjs/ember.js#17678
stefanpenner added a commit to broccolijs/broccoli-persistent-filter that referenced this issue Mar 3, 2019
@stefanpenner
Bump hash-for-dep fixing emberjs/ember.js#17678
ee302dc
@stefanpenner stefanpenner mentioned this issue Mar 3, 2019
Merged
@stefanpenner
Copy link
Member

@mixonic's revert addressed the issue and #17694 unreverts \w fix

stefanpenner added a commit to broccolijs/broccoli-persistent-filter that referenced this issue Mar 3, 2019
@stefanpenner
Bump hash-for-dep fixing emberjs/ember.js#17678 (#161)
357c244
@ppcano ppcano mentioned this issue Mar 3, 2019
Merged
This was referenced Dec 9, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@stefanpenner @mixonic @rwjblue @pzuraq @ppcano @dbrusilovsky