[Regression] disconnectOutlet can't reach across routes

[ghost]

Disconnecting an outlet used to work even from a sub route. Now the element doesn't get removed from the DOM.

Modal doesn't get removed In Ember 1.11.0-beta.5: http://emberjs.jsbin.com/dofohetuhu/5/edit
Modal gets removed in Ember 1.11.0-beta.1: http://emberjs.jsbin.com/dofohetuhu/3/edit

Seems to have started from beta.2, after this change ba1d1a6

[mutewinter]

👍 also experiencing this on 1.11.0-beta.5

[mutewinter]

My experience is that a controller triggering the disconnect via a triggerAction that hits the application controller fails. My temporary fix was to create a bugFixDisconnectOutlet function that calls disconnectOutlet twice with the same arguments.

[mutewinter]

My experience is that a controller triggering the disconnect via a triggerAction that hits the application controller fails. My temporary fix was to create a bugFixDisconnectOutlet function that calls disconnectOutlet twice with the same arguments.

Actually, it turns out that I'm needing to call disconnectOutlet for every time the outlet was rendered.

http://emberjs.jsbin.com/xibuvaduzu/1/edit?html,js,output

Test 1

1. Click Open Layer
2. Click Close
3. Modal closes fine

Test 2

1. Click Open Layer
2. Click Open Layer Again
3. Click Close
4. Modal does not close
5. Click Close
6. Modal closes

Close needs to be clicked N number of times, where N is the number of times the outlet was rendered into.

[mutewinter]

And here's my temporary fix:

  bugFixRender: (view, options) ->
    @disconnectOutlet(
      outlet: options.outlet
      parentView: options.into
    )
    @render(view, options)

[ef4]

PR #10683 addresses @mutewinter 's comment about stacking multiple calls to render.

The original issue reported by @Soliah is a regression and still open.

[ef4]

Now I've extended PR #10683 to also close the original issue.