Skip to content

Commit

Permalink
[BUGFIX beta] Update rendering engine to improve error ergonomics.
Browse files Browse the repository at this point in the history 
Fixes two major issues:

* Ensure "pause on uncaught" exceptions pauses in correct location
  (glimmerjs/glimmer-vm#1172)
* Log template heirarchy to the console for any errors thrown during
  rendering (glimmerjs/glimmer-vm#1169)

(cherry picked from commit e8cfd08)
  • Loading branch information
@rwjblue @kategengler
rwjblue authored and kategengler committed Oct 19, 2020
1 parent a6b8dfe commit 2ed32dd
Show file tree
Hide file tree
Showing 2 changed files with 119 additions and 119 deletions.
18 changes: 9 additions & 9 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -74,16 +74,16 @@
},
"devDependencies": {
"@babel/preset-env": "^7.9.5",
"@glimmer/compiler": "0.62.1",
"@glimmer/compiler": "0.62.3",
"@glimmer/env": "^0.1.7",
"@glimmer/global-context": "0.62.1",
"@glimmer/interfaces": "0.62.1",
"@glimmer/node": "0.62.1",
"@glimmer/opcode-compiler": "0.62.1",
"@glimmer/program": "0.62.1",
"@glimmer/reference": "0.62.1",
"@glimmer/runtime": "0.62.1",
"@glimmer/validator": "0.62.1",
"@glimmer/global-context": "0.62.3",
"@glimmer/interfaces": "0.62.3",
"@glimmer/node": "0.62.3",
"@glimmer/opcode-compiler": "0.62.3",
"@glimmer/program": "0.62.3",
"@glimmer/reference": "0.62.3",
"@glimmer/runtime": "0.62.3",
"@glimmer/validator": "0.62.3",
"@simple-dom/document": "^1.4.0",
"@types/qunit": "^2.9.1",
"@types/rsvp": "^4.0.3",
Expand Down
220 changes: 110 additions & 110 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -929,152 +929,152 @@
minimatch "^3.0.4"
strip-json-comments "^3.1.1"

"@glimmer/compiler@0.62.1":
version "0.62.1"
resolved "https://registry.yarnpkg.com/@glimmer/compiler/-/compiler-0.62.1.tgz#4b80f1cd55d39858e602080de03db6febf5b9303"
integrity sha512-s709URSvV3IzSmyyKd1t2twlxcjM7OZgh+pmehwjEEVXSm6nDrAtJcBw8OBPw0AL6TnArf5xHTHtH4EJJ8fyAg==
dependencies:
"@glimmer/interfaces" "0.62.1"
"@glimmer/syntax" "0.62.1"
"@glimmer/util" "0.62.1"
"@glimmer/wire-format" "0.62.1"
"@glimmer/compiler@0.62.3":
version "0.62.3"
resolved "https://registry.yarnpkg.com/@glimmer/compiler/-/compiler-0.62.3.tgz#10b9dcddeed47fd151f4af24c3c4ff02fd44159c"
integrity sha512-Ouo3BFS1ASJ4HdLvqie5VeNHfZAwDuWz4kVlDIMBTTJxcWZ0SAlCCfRHBTwiSrJ+1vy0Bd12iGsRzyFkTRa/Vg==
dependencies:
"@glimmer/interfaces" "0.62.3"
"@glimmer/syntax" "0.62.3"
"@glimmer/util" "0.62.3"
"@glimmer/wire-format" "0.62.3"
"@simple-dom/interface" "^1.4.0"

"@glimmer/encoder@0.62.1":
version "0.62.1"
resolved "https://registry.yarnpkg.com/@glimmer/encoder/-/encoder-0.62.1.tgz#75baeef7b923515ccfee778d99b1c61a5541050a"
integrity sha512-zlGhEYhWP+DSHumbJqckgUhFzhScze6D5ys69A3iJrmiDOYSs2uaRvonAKl7aQS4FGoUhelWfQT0xvWxD/u5OQ==
"@glimmer/encoder@0.62.3":
version "0.62.3"
resolved "https://registry.yarnpkg.com/@glimmer/encoder/-/encoder-0.62.3.tgz#dce2aa494319820198b955479915a39c86ddee3b"
integrity sha512-QCRxuWgn9OXarktjrLLKiSU+0Z8fYh756uqmuFVmlV0egiu7bt6MaPDBWG7eZBfAoUQ7H+DYrtXsYhbUYcPh3A==
dependencies:
"@glimmer/interfaces" "0.62.1"
"@glimmer/vm" "0.62.1"
"@glimmer/interfaces" "0.62.3"
"@glimmer/vm" "0.62.3"

"@glimmer/env@0.1.7", "@glimmer/env@^0.1.7":
version "0.1.7"
resolved "https://registry.yarnpkg.com/@glimmer/env/-/env-0.1.7.tgz#fd2d2b55a9029c6b37a6c935e8c8871ae70dfa07"
integrity sha1-/S0rVakCnGs3psk16MiHGucN+gc=

"@glimmer/global-context@0.62.1":
version "0.62.1"
resolved "https://registry.yarnpkg.com/@glimmer/global-context/-/global-context-0.62.1.tgz#41f6a130a235361cdb853ba6da276d4b84fd0fee"
integrity sha512-ZqLPa6KZitYbvlQCE9oyy6h7MTEwV0MqPgtrlb2nAKDZ8lZ90pzVvVNEmXpr6lkajEggISCt3GDsl8W/2IiBeQ==
"@glimmer/global-context@0.62.3":
version "0.62.3"
resolved "https://registry.yarnpkg.com/@glimmer/global-context/-/global-context-0.62.3.tgz#d77f03d26aea0cb2a2275d0b7d71f52fee7ca9d5"
integrity sha512-TjjiuR0urcL2wrY3DMoXkU4838UbG2T9MIUE9Wsh1W9XwoyFMz6CqMOgq2/k7dASYzyAY2dhQB6Y+rEHibAZgA==
dependencies:
"@glimmer/env" "^0.1.7"

"@glimmer/interfaces@0.62.1":
version "0.62.1"
resolved "https://registry.yarnpkg.com/@glimmer/interfaces/-/interfaces-0.62.1.tgz#42e4021569a00ca60d469ef06cc0c719883d109e"
integrity sha512-Ui4u/0G0zOYeDuz497DQ/isOgd43r6zNO0JdsDeVw1D/tYQQHR1Xk/1YRKC9jK2n5oicMYKVyEeT62Ec2rL/Jg==
"@glimmer/interfaces@0.62.3":
version "0.62.3"
resolved "https://registry.yarnpkg.com/@glimmer/interfaces/-/interfaces-0.62.3.tgz#8ad314d66d1a43197663509806e1cc2088db6741"
integrity sha512-bhbKs5vfys4mo+LRxcA4bfMl2zGn+43et4uAzsYppuNPSkP7rwdPD+mLXTYQRkTm0G5K4SnyxDPxMsWCWUNuTw==
dependencies:
"@simple-dom/interface" "^1.4.0"

"@glimmer/low-level@0.62.1":
version "0.62.1"
resolved "https://registry.yarnpkg.com/@glimmer/low-level/-/low-level-0.62.1.tgz#0fd0870d1ec97d6a81e29ac66ed69e2e17f3094a"
integrity sha512-sMNcGWdfgthq0DWHqawMJXoXuhtlA0dY3Y63HyMe5aB94JXw/0SujKdysjG5ImqgRxADcPj39EjS9aJO5AfW2A==
"@glimmer/low-level@0.62.3":
version "0.62.3"
resolved "https://registry.yarnpkg.com/@glimmer/low-level/-/low-level-0.62.3.tgz#05f8b09b4eac5b6c8196c7601747ca88c4f147a0"
integrity sha512-VeQN5peF20MiSLPkWjFqceLCrbfnYAopCoDCfZwubgNBcEESvbQGQ0fqKNs6pMbkhD4n22usJWiCAFQbMCOgkA==

"@glimmer/node@0.62.1":
version "0.62.1"
resolved "https://registry.yarnpkg.com/@glimmer/node/-/node-0.62.1.tgz#48ecee29f596f833d7dc50a27abb83db8a31a711"
integrity sha512-gUaQJ950x3BSMKR/PPRD7P+dycqdrYd1gWBTvXDNuAHantH6lLofkGEJmeeDHq+nw8B/CXkD9uqn7H94jiOttg==
"@glimmer/node@0.62.3":
version "0.62.3"
resolved "https://registry.yarnpkg.com/@glimmer/node/-/node-0.62.3.tgz#cb571804b7daaca1b314dc0b493d95dc9d2f3e1a"
integrity sha512-ru0shgN6l2xzFE5aCchURXYXdsDbLtkm9qm3nV5AIjNhW9/Z2pnmVwwDysBN5PbXIyF0hboRpDJJ0fgV9ml0Ug==
dependencies:
"@glimmer/interfaces" "0.62.1"
"@glimmer/runtime" "0.62.1"
"@glimmer/util" "0.62.1"
"@glimmer/interfaces" "0.62.3"
"@glimmer/runtime" "0.62.3"
"@glimmer/util" "0.62.3"
"@simple-dom/document" "^1.4.0"
"@simple-dom/interface" "^1.4.0"

"@glimmer/opcode-compiler@0.62.1":
version "0.62.1"
resolved "https://registry.yarnpkg.com/@glimmer/opcode-compiler/-/opcode-compiler-0.62.1.tgz#86596ed10df791887de1f9d43d1e5bcead5878ec"
integrity sha512-OJ9kyBwFiPyxu8hNaHHadNlG7ujEu9SLwSJD+5p3lYO3aIbCr0XkQaPmYSgsXiTxtWU9lDLuUVowirHMk/0ZfQ==
dependencies:
"@glimmer/encoder" "0.62.1"
"@glimmer/interfaces" "0.62.1"
"@glimmer/program" "0.62.1"
"@glimmer/reference" "0.62.1"
"@glimmer/util" "0.62.1"
"@glimmer/vm" "0.62.1"
"@glimmer/wire-format" "0.62.1"

"@glimmer/program@0.62.1":
version "0.62.1"
resolved "https://registry.yarnpkg.com/@glimmer/program/-/program-0.62.1.tgz#8ad8ccdf0ae68b74c349314734b6fb127730da5e"
integrity sha512-0gGN2hJWMFFby6PKsCvVA+Yp2fjqR1sjATR3dgZfi8VVxF+VQbMVVLA52o3xuyNzSsVL6GahX6t+RwksR9TXKQ==
dependencies:
"@glimmer/encoder" "0.62.1"
"@glimmer/interfaces" "0.62.1"
"@glimmer/util" "0.62.1"

"@glimmer/reference@0.62.1":
version "0.62.1"
resolved "https://registry.yarnpkg.com/@glimmer/reference/-/reference-0.62.1.tgz#b4f2263634459673d3c839da04d47202deffb189"
integrity sha512-/bud6PB6yw89m9Vyg2CGwk5cwjYjRoA0ZJG3k5WDpLXXF/sHrMxdJFVtVcnmonKRuPzpduypvWzBDAxVdq7w0A==
"@glimmer/opcode-compiler@0.62.3":
version "0.62.3"
resolved "https://registry.yarnpkg.com/@glimmer/opcode-compiler/-/opcode-compiler-0.62.3.tgz#f0a1f2d4984aa4389b7510e4da0642cbfc94caab"
integrity sha512-7ACPdDcT0Aa3RALnMxyxinpVnOQS1jVNgilNtryrocHsaIGRxuRj+GvvwJdCiP/xI4OIzMM30qcDeyKru9TtIw==
dependencies:
"@glimmer/encoder" "0.62.3"
"@glimmer/interfaces" "0.62.3"
"@glimmer/program" "0.62.3"
"@glimmer/reference" "0.62.3"
"@glimmer/util" "0.62.3"
"@glimmer/vm" "0.62.3"
"@glimmer/wire-format" "0.62.3"

"@glimmer/program@0.62.3":
version "0.62.3"
resolved "https://registry.yarnpkg.com/@glimmer/program/-/program-0.62.3.tgz#eb22f1864b35d4e626733b099ed1058342e09d84"
integrity sha512-fVfM/myEkGERug/d6O3iVxIInTcQ2Tsr4Lp21UR+aEeDsC99bnfuZjTtG1vvmVeduraqjxvStS/9GBb/zdOJ8Q==
dependencies:
"@glimmer/encoder" "0.62.3"
"@glimmer/interfaces" "0.62.3"
"@glimmer/util" "0.62.3"

"@glimmer/reference@0.62.3":
version "0.62.3"
resolved "https://registry.yarnpkg.com/@glimmer/reference/-/reference-0.62.3.tgz#23c6861eaad57def8d8ad54c94aefd1f6fa5541e"
integrity sha512-pAyZTFhswKyXOyQzcjh1DA7BMH8WNqjswfeAu8V98b4vfAYb2JYH3IdUadTDwsM5vbYou4e01+dFSAaPHex/lg==
dependencies:
"@glimmer/env" "^0.1.7"
"@glimmer/global-context" "0.62.1"
"@glimmer/interfaces" "0.62.1"
"@glimmer/util" "0.62.1"
"@glimmer/validator" "0.62.1"
"@glimmer/global-context" "0.62.3"
"@glimmer/interfaces" "0.62.3"
"@glimmer/util" "0.62.3"
"@glimmer/validator" "0.62.3"

"@glimmer/runtime@0.62.1":
version "0.62.1"
resolved "https://registry.yarnpkg.com/@glimmer/runtime/-/runtime-0.62.1.tgz#b172f4315cfec831b380f7814c73021d78789501"
integrity sha512-yrpK1Hvj1GdiVHNyVcN12c/WMqxercdYMMn2ZEiaX9Oc+OcY7ojUK2gkOEoqPx905T8+q27yIc8Xs+89jKAVeg==
"@glimmer/runtime@0.62.3":
version "0.62.3"
resolved "https://registry.yarnpkg.com/@glimmer/runtime/-/runtime-0.62.3.tgz#1c254b58429f00e12005540a5da64ef60808de30"
integrity sha512-Ru8zDt0bNWtjdj/bdCdJ0rZSKVITdE3s3RRfMqpBRgbKwVWIXWfpJRcOteHcQnMIsAXs6QqE4st9hZTaoNOLGQ==
dependencies:
"@glimmer/env" "0.1.7"
"@glimmer/global-context" "0.62.1"
"@glimmer/interfaces" "0.62.1"
"@glimmer/low-level" "0.62.1"
"@glimmer/program" "0.62.1"
"@glimmer/reference" "0.62.1"
"@glimmer/util" "0.62.1"
"@glimmer/validator" "0.62.1"
"@glimmer/vm" "0.62.1"
"@glimmer/wire-format" "0.62.1"
"@glimmer/global-context" "0.62.3"
"@glimmer/interfaces" "0.62.3"
"@glimmer/low-level" "0.62.3"
"@glimmer/program" "0.62.3"
"@glimmer/reference" "0.62.3"
"@glimmer/util" "0.62.3"
"@glimmer/validator" "0.62.3"
"@glimmer/vm" "0.62.3"
"@glimmer/wire-format" "0.62.3"
"@simple-dom/interface" "^1.4.0"

"@glimmer/syntax@0.62.1":
version "0.62.1"
resolved "https://registry.yarnpkg.com/@glimmer/syntax/-/syntax-0.62.1.tgz#60f0b14c8503f059b9b73065a2d86f9ca6c6e3f3"
integrity sha512-pjnPouu3tVJ5sDcpYCv9hyodJW6T07LvOjsGQ+QT5TdMqN4hoc4iK3dkdrRh+dkNcUsBxFQhxOtAbwOVSgtVtg==
"@glimmer/syntax@0.62.3":
version "0.62.3"
resolved "https://registry.yarnpkg.com/@glimmer/syntax/-/syntax-0.62.3.tgz#8c4abd245a54e8cc084a47ab4a65c33194256fda"
integrity sha512-PU4PpMg9UOeYFTODkHN9K6As74lm16XGEQAQbd59oAbvGRu5OAIWFtSU4sMexpKOXu6iJacFO5udX7gVTACRQQ==
dependencies:
"@glimmer/interfaces" "0.62.1"
"@glimmer/util" "0.62.1"
"@glimmer/interfaces" "0.62.3"
"@glimmer/util" "0.62.3"
"@handlebars/parser" "^1.1.0"
simple-html-tokenizer "^0.5.9"
simple-html-tokenizer "^0.5.10"

"@glimmer/util@0.62.1":
version "0.62.1"
resolved "https://registry.yarnpkg.com/@glimmer/util/-/util-0.62.1.tgz#44221aca6a8bb06791b0057db9b1d72330c08094"
integrity sha512-e6YTDAgEh8fqarhyN+0ncXOixLn5Wt12/IWdwKmtGIhdALOc/lWbJfrxlmKD+kkFTTjUVJUKm1Y6pxUyXOo4Ww==
"@glimmer/util@0.62.3":
version "0.62.3"
resolved "https://registry.yarnpkg.com/@glimmer/util/-/util-0.62.3.tgz#d6fc5d64e5e97cbec02b5fcf8a8c78c7f67dc6f5"
integrity sha512-HImkS2UJuZYPxyjXPFL9PS659kwjNcRIr5hnUo1PzrPfyZxXwWys2+vTxIv34tI1xkgkQmB1pB0S8pCdNrJY5w==
dependencies:
"@glimmer/env" "0.1.7"
"@glimmer/interfaces" "0.62.1"
"@glimmer/interfaces" "0.62.3"
"@simple-dom/interface" "^1.4.0"

"@glimmer/validator@0.62.1":
version "0.62.1"
resolved "https://registry.yarnpkg.com/@glimmer/validator/-/validator-0.62.1.tgz#30240a5d7bb574b833fdb39e90202dbbdde9886c"
integrity sha512-pewpCA8oh4ONnflgHDhuMYkS4D0sdkxrc9iNwf+LMweGGSszAa34hoiC4noLKdYPGx+oRwi/JXwUPf93cvj2+g==
"@glimmer/validator@0.62.3":
version "0.62.3"
resolved "https://registry.yarnpkg.com/@glimmer/validator/-/validator-0.62.3.tgz#241d97c3a42130a4d06d821de66147e50602ffe5"
integrity sha512-bge8EhoWvZNDvpfRI5BVvoT1E1+8GsYOWqOYIjXmQJObzXUE6KWgLMI1RGGcS+PItrAnniS1nv+hVdqk4aHDQQ==
dependencies:
"@glimmer/env" "^0.1.7"
"@glimmer/global-context" "0.62.1"
"@glimmer/global-context" "0.62.3"

"@glimmer/vm@0.62.1":
version "0.62.1"
resolved "https://registry.yarnpkg.com/@glimmer/vm/-/vm-0.62.1.tgz#418242bfcac4570872543a2a5c5c7fcdab33a690"
integrity sha512-W1bYb47jHmJYQIlvEtnrAUWZjbhH+CL83jiIoWBELhOAbiHUUdcmtjZlO3sweCHDsLz+9FQlTWOJuBoOCMRdZg==
"@glimmer/vm@0.62.3":
version "0.62.3"
resolved "https://registry.yarnpkg.com/@glimmer/vm/-/vm-0.62.3.tgz#b0ce8a7cf3dba9146735d4b58f163495c03f0cfb"
integrity sha512-CRs/BdBBd6yu43h1aZStJXrfRwQwbpPTZ/EWAfH90cwjecDoYnjpJX+HnEDqSg+XNk+YgRo0j7cHTIieHju3jQ==
dependencies:
"@glimmer/interfaces" "0.62.1"
"@glimmer/util" "0.62.1"
"@glimmer/interfaces" "0.62.3"
"@glimmer/util" "0.62.3"

"@glimmer/wire-format@0.62.1":
version "0.62.1"
resolved "https://registry.yarnpkg.com/@glimmer/wire-format/-/wire-format-0.62.1.tgz#4b210a6746dd2430e891e4ce4e2c9a743d703bd7"
integrity sha512-oLmIosr7RNk6BrZvOKj/NhkZ4/rWqYiQ/nGqzZzwvLY7HZlWmzDcpVsOJtIGOKFO33zHgkEBRtfXDo1+CmmSWQ==
"@glimmer/wire-format@0.62.3":
version "0.62.3"
resolved "https://registry.yarnpkg.com/@glimmer/wire-format/-/wire-format-0.62.3.tgz#2fcbd95461b8bf6a3dfa88cb5357074bcff82ca2"
integrity sha512-4Lrk6Vno+3GOihSQMBg4yOP/HFmwiVj18ntbQPPF2+D9x174ydywmdWO5AGn3VNFPojomhatgdUezZ0+czC2WQ==
dependencies:
"@glimmer/interfaces" "0.62.1"
"@glimmer/util" "0.62.1"
"@glimmer/interfaces" "0.62.3"
"@glimmer/util" "0.62.3"

"@handlebars/parser@^1.1.0":
version "1.1.0"
Expand Down Expand Up @@ -8396,10 +8396,10 @@ simple-dom@^1.4.0:
"@simple-dom/serializer" "^1.4.0"
"@simple-dom/void-map" "^1.4.0"

simple-html-tokenizer@^0.5.9:
version "0.5.9"
resolved "https://registry.yarnpkg.com/simple-html-tokenizer/-/simple-html-tokenizer-0.5.9.tgz#1a83fe97f5a3e39b335fddf71cfe9b0263b581c2"
integrity sha512-w/3FEDN94r4JQ9WoYrIr8RqDIPZdyNkdpbK9glFady1CAEyD97XWCv8HFetQO21w81e7h7Nh59iYTyG1mUJftg==
simple-html-tokenizer@^0.5.10:
version "0.5.10"
resolved "https://registry.yarnpkg.com/simple-html-tokenizer/-/simple-html-tokenizer-0.5.10.tgz#0843e4f00c9677f1c81e3dfeefcee0a4aca8e5d0"
integrity sha512-1DHMUmvUOGuUZ9/+cX/+hOhWhRD5dEw6lodn8WuV+T+cQ31hhBcCu1dcDsNotowi4mMaNhrLyKoS+DtB81HdDA==

slash@^3.0.0:
version "3.0.0"
Expand Down

0 comments on commit 2ed32dd

Please sign in to comment.