Skip to content
This repository has been archived by the owner on Sep 21, 2020. It is now read-only.

Initial #1

Closed
wants to merge 5 commits into from
Closed

Initial #1

wants to merge 5 commits into from

Conversation

stefanpenner
Copy link
Member

No description provided.

@@ -0,0 +1,9 @@
The MIT License (MIT)

Copyright (c) 2015
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should likely be "Ember.js contributors"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Ember.js core team & contributors"?

@ebryn
Copy link
Member

ebryn commented Jun 21, 2015

There appear to be tests not included in this repo, such as:
https://github.com/emberjs/ember.js/pull/11484/files#diff-8600fa262132288b94b079e49d7e42a6L335

@cibernox
Copy link
Collaborator

I'll revisit this over the weekend. Should I address the feedback in this repo or in the original one? I'd need write access in that case

@stefanpenner
Copy link
Member Author

I'll revisit this over the weekend. Should I address the feedback in this repo or in the original one? I'd need write access in that case

i'll be around most of the weekend lets touch base tomorow :)

@cibernox
Copy link
Collaborator

I've updated https://github.com/cibernox/ember-proxy-controllers with this feedback.

Also extracted SortableMixin along with it's tests since it's going away too

@stefanpenner
Copy link
Member Author

@cibernox can you submit yours as a PR, so we can get this in?

@ebryn ebryn closed this Jan 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants