Upgrade to Ember 3.18 to fix list rendering issue #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
May 9, 2020
There is a good chance this may fix issues like #1195. I haven't dug in yet, but ember-source 3.17 has a bug with `{{#each}}` when the same key is used more than once, which is the kind of thing that could easily break vertical collection and is at least visually consistent with the errors reported by users. It was fixed in 3.18.1 via emberjs/ember.js#18941 but the fix was never made it to 3.17 in time. So, either way, we really should upgrade.
This was referenced May 9, 2020
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
There is a good chance this may fix issues like emberjs#1195. I haven't dug in yet, but ember-source 3.17 has a bug with `{{#each}}` when the same key is used more than once, which is the kind of thing that could easily break vertical collection and is at least visually consistent with the errors reported by users. It was fixed in 3.18.1 via emberjs/ember.js#18941 but the fix was never made it to 3.17 in time. So, either way, we really should upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a good chance this may fix issues like #1195. I haven't dug in yet, but ember-source 3.17 has a bug with
{{#each}}when the same key is used more than once, which is the kind of thing that could easily break vertical collection and is at least visually consistent with the errors reported by users. It was fixed in 3.18.1 via emberjs/ember.js#18941 but the fix was never made it to 3.17 in time. So, either way, we really should upgrade.