Update babel-plugin-ember-modules-api-polyfill to fix issues with invalid identifiers.

[rwjblue]

The babel plugin previously took an identifier and replaced it's name value with one that included a string like Ember.Foo. This is completely invalid (a string like Ember.Foo is actually a MemberExpression), but we got away with it because for the most part Babel happily printed whatever value you give it in that spot.

Unfortunately, this happy mistake has caused us quite a bit of pain due to Babel introducing new plugins that run as part of @babel/preset-env (e.g. to make sure that all identifiers would work properly on IE9), and those plugins properly sanitizing invalid identifiers.

The plugin was updated to avoid this mistake, and properly rewrite the identifiers with a member expression. It also added tests to confirm things are working as intended.

Fixes #316
Fixes #322
Fixes emberjs/ember.js#18992

[lukemelia]

Thanks for working on this @rwjblue!

I tried upgraded an addon that was having an issue with this (ember-keyboard), and while my yarn.lock-driven tests pass, my 3.12 ember-try build now fails with a different error:

➜  ember-keyboard git:(rfc/api-change) ✗ node_modules/.bin/ember try:one ember-lts-3.12
yarn install v1.22.4
[snip]
Build Error (broccoli-persistent-filter:Babel > [Babel: @glimmer/component]) in @glimmer/component/-private/ember-component-manager.ts

/Users/lmelia/p/ember/ember-keyboard/@glimmer/component/-private/ember-component-manager.ts: Property id of TSDeclareFunction expected node to be of a type ["Identifier"] but instead got "MemberExpression"

Let me know if it would be best for me to open a separate issue somewhere, or if I can provide any additional info.

[miguelcobain]

The same issue started happening to me as well on two of my apps.

[BarryThePenguin]

I'm seeing the same error in a number of apps and addons with ember-cli-babel@7.20.1

Apps are on v3.12
Addons, some v3.12, with a couple on v3.16

It looks like a mixed bag, so I'm taking a look to see why some would be failing while others aren't..

Build Error (broccoli-persistent-filter:Babel > [Babel: @ember-data/store]) in -private/system/model/internal-model.ts
--
  |  
  | /frontend/packages/activity-tracker/-private/system/model/internal-model.ts: Property left of TSQualifiedName expected node to be of a type ["TSEntityName"] but instead got "MemberExpression"

While another reads

Build Error (broccoli-persistent-filter:Babel > [Babel: @glimmer/component]) in @glimmer/component/-private/ember-component-manager.ts
--
  |  
  | /frontend/packages/get-config/@glimmer/component/-private/ember-component-manager.ts: Property id of TSDeclareFunction expected node to be of a type ["Identifier"] but instead got "MemberExpression"

[rwjblue]

https://github.com/babel/ember-cli-babel/releases/tag/v7.20.2 is out with the fix for the TS issue (thank you @fivetanley!). See ember-cli/babel-plugin-ember-modules-api-polyfill#110 for more explanation.