Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: small cleanups for style #8526

Merged
merged 4 commits into from
Mar 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions packages/request/src/-private/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -230,14 +230,13 @@ const FetchHandler = {
For context, it helps to understand a few of the use-cases that RequestManager
is intended to allow.

- to manage and return streaming content (such as video files)
- to fulfill a request from multiple sources or by splitting one request into multiple requests
- for instance one API call for a user and another for the user's friends
- or e.g. fulfilling part of the request from one source (one API, in-memory, localStorage, IndexedDB
etc.) and the rest from another source (a different API, a WebWorker, etc.)
- to coalesce multiple requests
- to decorate a request with additional info
- e.g. an Auth handler that ensures the correct tokens or headers or cookies are attached.
- to manage and return streaming content (such as video files)
- to fulfill a request from multiple sources or by splitting one request into multiple requests
- for instance one API call for a user and another for the user's friends
- or e.g. fulfilling part of the request from one source (one API, in-memory, localStorage, IndexedDB etc.) and the rest from another source (a different API, a WebWorker, etc.)
- to coalesce multiple requests
- to decorate a request with additional info
- e.g. an Auth handler that ensures the correct tokens or headers or cookies are attached.

----

Expand Down
11 changes: 9 additions & 2 deletions packages/request/src/fetch.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
/**
* A very basic Fetch Handler
* A basic Fetch Handler which converts a request into a
* `fetch` call presuming the response to be `json`.
*
* ```ts
* import Fetch from '@ember-data/request/fetch';
*
* manager.use([Fetch]);
* ```
*
* @module @ember-data/request/fetch
* @main @ember-data/request/fetch
Expand All @@ -16,7 +23,7 @@ const _fetch: typeof fetch =
throw new Error('No Fetch Implementation Found');
}) as typeof fetch);
/**
* A basic handler which onverts a request into a
* A basic handler which converts a request into a
* `fetch` call presuming the response to be `json`.
*
* ```ts
Expand Down
6 changes: 3 additions & 3 deletions tests/main/testem.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module.exports = {
ci: [
'--headless',
'--no-sandbox',
'--enable-logging',
// '--enable-logging',

// this may help debug CI in some situations
// '--enable-logging',
Expand Down Expand Up @@ -55,7 +55,7 @@ module.exports = {
'--window-size=1440,900',
'--proxy-bypass-list=*',
"--proxy-server='direct://'",
],
].filter(Boolean),
dev: [
'--headless',
'--no-sandbox',
Expand Down Expand Up @@ -88,7 +88,7 @@ module.exports = {
'--window-size=1440,900',
'--proxy-bypass-list=*',
"--proxy-server='direct://'",
],
].filter(Boolean),
},
Firefox: {
ci: ['--headless', '--width=1440', '--height=900'],
Expand Down