Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: <Cache>.changedAttrs should be empty if no local mutations exist #8335

Merged
merged 3 commits into from
Dec 7, 2022
Merged

fix: <Cache>.changedAttrs should be empty if no local mutations exist #8335

merged 3 commits into from
Dec 7, 2022

Conversation

timmorey
Copy link
Contributor

@timmorey timmorey commented Dec 6, 2022 •
edited by runspired
Loading

resolves #8329

@timmorey timmorey mentioned this pull request Dec 6, 2022
Closed
@runspired runspired added 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🏷️ bug This PR primarily fixes a reported issue labels Dec 7, 2022
@runspired runspired changed the title Failing test for Model.changedAttributes regression fix: <Cache>.changedAttrs should be empty if no local mutations exist Dec 7, 2022
@runspired runspired merged commit 55e137e into emberjs:master Dec 7, 2022
@runspired runspired removed the 🎯 release PR should be backported to release label Dec 7, 2022
@robbytx
Copy link
Contributor

robbytx commented Mar 23, 2023

@runspired can this be backported to LTS (4.8)? I just realized it is affecting my app.

@runspired
Copy link
Contributor

I think it was but yes, if not please open a PR

@ptgamr
Copy link

ptgamr commented Apr 17, 2023

@runspired Nah, it wasn't back ported to the LTS 4.8.7, still happening, this is a blocker for our app - what's the processs of creating a back port? I can help with that

@ptgamr
Copy link

ptgamr commented Apr 17, 2023 •
edited
Loading

Tried to use patch-package to have a quick fix, but it's not possible with the way ember-data organize its packages.

@runspired
Copy link
Contributor

Tried to use patch-package to have a quick fix, but it's not possible with the way ember-data organize its packages.

It's certainly possible, we don't do anything non-standard for our packages. Likely you're just noticing that the ember-data package simply re-exports all the actual packages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model.changedAttributes not cleaned out after save
4 participants
@timmorey @robbytx @runspired @ptgamr