[CHORE] improve comment bot #6820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Asset Size Report for fe7aeb2 EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset Full Asset Analysis |
|
Performance Report for fe7aeb2 Relationship Analysis |
- changes the comment-bot to update existing comments instead of deleting old comments - fixes the bug that was preventing deletion of old comments - fixes the performance analysis script to also post a comment correctly (it's been failing to do so although trying for some time) You can see the effects of the updates (edit history on the pr comments) within this PR. Overall it seems like a good change, although I dislike how the comment time stamp remains the time of the very original comment instead of showing the time edited. This makes it harder to judge quickly if it is the most recent analysis, although checking the commit sha that is printed will verify.
08dacfa to
fe7aeb2
Compare
rwjblue
approved these changes
Nov 28, 2019
|
Ilios failure seems to be due to them having merged a bad PR |
|
cc @jrjohnson |
|
Thanks for the heads up @runspired looks like we have a floating dependency with a breaking change. It's our own package so entirely my fault. I'll get that cleaned up ASAP. |
igorT
reviewed
Dec 1, 2019
| @@ -33,9 +33,10 @@ API_VERSION=v3 | |||
| API_HEADER="Accept: application/vnd.github.${API_VERSION}+json; application/vnd.github.antiope-preview+json" | |||
| AUTH_HEADER="Authorization: token ${GITHUB_TOKEN}" | |||
|
|
|||
| delete_comment_if_exists() { | |||
| update_comment_if_exists() { | |||
There was a problem hiding this comment.
Unrelated to this PR but as these grow/become more complicated should we rewrite them in js?
igorT
reviewed
Dec 1, 2019
| @@ -46,15 +47,19 @@ delete_comment_if_exists() { | |||
| # We have found our comment. | |||
| # Delete it. | |||
igorT
reviewed
Dec 1, 2019
| } | ||
|
|
||
| post_comment() { | ||
| echo "Posting new comment" |
|
My gmail sends many ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
You can see the effects of the updates (edit history on the pr comments) within this PR. Overall it seems like a good change, although I dislike how the comment time stamp remains the time of the very original comment instead of showing the time edited. This makes it harder to judge quickly if it is the most recent analysis, although checking the commit sha that is printed will verify.