Preserve hasmany order when pushing child #5806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@runspired do you know why this PR is failing with the good old runloop autorun in testing error but only in LTS 2.18? |
|
@runspired this is an important fix for us and has left us marooned on 3.6. Do you have a moment to see why it's only failing on the old LTS? |
|
closed in favour of #7402 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my app I have a websocket receiving jsonapi updates from the server. I use store.push to put these into ember-data.
If I push a model which is part of an ordered hasMany, it gets bumped to the end of the list.
I can't reproduce this in a test, although I've tried to in this PR. My fix, however, works in the app. It is also a nice optimisation when pushing a hasMany with very few changes. Previously every item was removed and then added again. I skip that if the item in the old and new array matches at this index.