Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blueprints): remove second string argument from transform tests #5657

Merged
merged 1 commit into from
Oct 2, 2018
Merged

fix(blueprints): remove second string argument from transform tests #5657

merged 1 commit into from
Oct 2, 2018

Conversation

makepanic
Copy link
Contributor

fixes #5656

@makepanic
Copy link
Contributor Author

I just noticed that yarn updated the yarn.lock with integrity. Should i remove that from the PR?

@dcyriller
Copy link
Contributor

Don't have any write access, but recently worked on blueprints. LGTM 👍

(The issue don't affect other blueprints)

@runspired
Copy link
Contributor

@makepanic yeah, please remove the yarn.lock change. Otherwise LGTM

@makepanic
Copy link
Contributor Author

I've removed the yarn.lock changes

@runspired runspired merged commit c80e7c7 into emberjs:master Oct 2, 2018
@runspired
Copy link
Contributor

Thanks @makepanic !

@runspired runspired mentioned this pull request Oct 4, 2018
Closed
@makepanic makepanic deleted the issues/5656 branch March 10, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

transform-test blueprint uses qunit module wrong
3 participants
@makepanic @dcyriller @runspired