Failing test for unloadAll scenario with hasMany relationship that ends up wrong #5572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukemelia thanks! I'll investigate what the next step is |
|
Cool @runspired. FWIW, we decided to temporarily run with a fork that has the optimization line I referenced commented out. |
|
@lukemelia any chance you got stuck here at some point? I doubt this is still a bug but if it is happy to get the test caught up and a fix investigated. Because of the way the relationship layer and unload works today this test probably isn't a meaningful addition anymore unless there's still a known issue it manages to catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simplified failing test for an issue we experienced in our app.
The test passes when an optimization is commented out, specifically the conditional here:
data/addon/-legacy-private/system/relationships/state/relationship.js
Line 304 in ece0494
We're happy to work on a fix but are not sure where to go from here.