Add failing test when changing parent and unloading original parent

[lsg-braymon]

Bug wherein changing the parent of a child then unloading the original parent sets the child association to null.
Setup:

  // This is the association set up
  class Child extends DS.Model {
    @belongsTo('parent')
  }

  class Parent extends DS.Model {
    @hasMany('child')
  }

  // Assume here that `child` is already associated to Parent 1
  const parent1 = this.store.peekRecord('parent', 1)
  const child = this.store.peekRecord('child', 1)

  const parent2 = this.store.peekRecord('parent', 2)
  set(child, 'parent', parent2) // We are not commiting to the database yet at this point

  // Delete Parent 1
  parent1.unloadRecord()
  child.parent // Returns null. Parent 2 is expected

Current work around:

// Assume here that `child` is already associated to Parent 1
  const parent1 = this.store.peekRecord('parent', 1)
  const child = this.store.peekRecord('child', 1)

  const parent2 = this.store.peekRecord('parent', 2)
  const payload = {
    data: {
      type: 'child',
      id: child.id,
      relationships: {
        parent: {
          data: { type: 'parent', id: parent2.id }
        }
      }
    }
  }
  this.store.pushPayload(payload) // Instead of set(child, 'parent', parent2)

  // Delete Parent 1
  parent1.unloadRecord()
  child.parent // Returns Parent 2

[runspired]

At first glance this looks good, will want to poke around at it locally before merging to gain more confidence that this is the correct fix.

[lsg-braymon]

@runspired Got it. Thank you.

[lsg-braymon]

Hi @runspired just wanted to ask if there are updates on this bug. Thank you!

[runspired]

@lsg-braymon sadly I didn't spend the time to review this yet, thanks for the reminder! Will attach some labels so I don't forget :P

[richard-viney]

I work with @lsg-braymon and have just rebased this PR against the latest master and added some more detail into the commit message.

Is there anything we can do to help with getting this fix included as part of an upcoming release?

Thanks!

[richard-viney]

Thanks heaps, is this change a candidate for inclusion in the current 3.10 betas?

[runspired]

@richard-viney yes, but I haven’t gotten publishing to work correctly with the monorepo just yet. Need to tweak the tsconfig some more so that prepublish works. If you have a moment to help on that this weekend I’d love it cause I don’t have much time ❤️

TL;DR npm prebublish command needs to work correctly in each individual package and is broken in a few atm.

[richard-viney]

Sure thing, I'll take a look later today

[runspired]

@richard-viney the beta branch has some work towards it to bring back to master. Trying to release last night was an adventure 😂

[runspired]

@richard-viney ended up with a little time to poke at it and think I resolved the issues :) Thank you for the offer, if you do have some time and want to contribute I left some notes in the fix-pr of some things we need to still do to the prepublish infra prior to our next stable release.

#6050