Remove blueprints for Mocha < 0.12. #5225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ember-cli-mocha@0.12.0 was released quite some time ago (on 2016-11-23), and by all accounts has been well adopted. Supporting both mocha test blueprints indefinitely is untenable, and now seems like as good a time as any to drop the blueprints for the older syntax. Note: this does *not* remove support for anything, it merely makes it slightly less convienient to create new test files for adapter/model/serializer/transform objects when your application is using Mocha < 0.12.
This is unblocked by removing the need to "Fake" the version checker in the blueprint test suite (the way ember-cli-blueprint-test-helpers fakes out ember-cli-version-checker@1 no longer works with ember-cli-version-checker@2).
Turbo87
approved these changes
Oct 12, 2017
|
Yep, that was exactly my thinking. |
igorT
pushed a commit
that referenced
this pull request
Jan 29, 2018
* Remove blueprints for Mocha < 0.12. ember-cli-mocha@0.12.0 was released quite some time ago (on 2016-11-23), and by all accounts has been well adopted. Supporting both mocha test blueprints indefinitely is untenable, and now seems like as good a time as any to drop the blueprints for the older syntax. Note: this does *not* remove support for anything, it merely makes it slightly less convienient to create new test files for adapter/model/serializer/transform objects when your application is using Mocha < 0.12. * Update to the latest ember-cli-version-checker. This is unblocked by removing the need to "Fake" the version checker in the blueprint test suite (the way ember-cli-blueprint-test-helpers fakes out ember-cli-version-checker@1 no longer works with ember-cli-version-checker@2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-cli-mocha@0.12.0 was released quite some time ago (on 2016-11-23), and by all accounts has been well adopted. Supporting both mocha test blueprints indefinitely is untenable, and now seems like as good a time as any to drop the blueprints for the older syntax.
Note: this does not remove support for anything, it merely makes it slightly less convienient to create new test files for adapter/model/serializer/transform objects when your application is using Mocha < 0.12.
/cc @Turbo87