Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] proxy meta on PromiseArray #5213

Merged
merged 1 commit into from
Oct 9, 2017
Merged

[BUGFIX beta] proxy meta on PromiseArray #5213

merged 1 commit into from
Oct 9, 2017

Conversation

pangratz
Copy link
Member

@pangratz pangratz commented Oct 6, 2017

This closes #5129.

I am unsure if this is the correct way to fix this or if something else is fishy...

Maybe it's because of this 🤔:

// yes we are touching `this` before super, but ArrayProxy has a bug that requires this.
this.set('content', this.get('content') || Ember.A());

@bmac bmac merged commit fe4ac46 into emberjs:master Oct 9, 2017
@bmac
Copy link
Member

bmac commented Oct 9, 2017

Thanks @pangratz.

@pangratz pangratz deleted the promise-array-meta branch October 9, 2017 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta data not proxied
2 participants