Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4366: EmbeddedRecordsMixin embeds the record, not the snapshot #4374

Merged
merged 1 commit into from
May 10, 2016

Conversation

dnachev
Copy link

@dnachev dnachev commented May 8, 2016

The change replaces references to snapshot.record.serialize() with snapshot.serialize() in the EmbeddedRecordsMixin to ensure that the snapshot state is serialized rather than the current state of the record.

@pangratz
Copy link
Member

pangratz commented May 8, 2016

LGTM, thanks @dnachev.

@wecc can you do a double check if this looks good to you as well?

@wecc
Copy link
Contributor

wecc commented May 9, 2016

👍

@pangratz
Copy link
Member

pangratz commented May 9, 2016

thanks @wecc

@dnachev I would consider this a bugfix, can you update the commit message to something like [BUGFIX beta] Reuse snapshot when serializing embedded relationships... ?

@dnachev dnachev force-pushed the fix-embedded-records-serialize branch from 8b84ab0 to 91454da Compare May 10, 2016 07:08
@dnachev
Copy link
Author

dnachev commented May 10, 2016

@pangratz I've changed the commit message. Let me know if you need something else.

@pangratz pangratz merged commit afeb5e0 into emberjs:master May 10, 2016
@pangratz
Copy link
Member

Thanks @dnachev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants