[BUGFIX beta] Allow optional spaces when parsing response headers #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0fe5ef to
f029211
Compare
656412f to
e97e82e
Compare
Fixes emberjs#4122 - Allows header field-value without preceding whitespace - Removes leading/trailing whitespace from header field-names - Removes leading/trailing whitespace from header field-values - Moves `parseResponseHeaders` function out of `DS.RestAdapter` to its own module The main reason for moving to a module was to make it easier to unit test in order to document current behavior before making the fix. Let me know if this is undesirable.
e97e82e to
dce22e3
Compare
| let headerPairs = headersString.split(CLRF); | ||
|
|
||
| headerPairs.forEach((header) => { | ||
| let [field, ...value] = header.split(':'); |
|
This looks very good to me 👍 . Much more readable now! Thanks @HeroicEric! |
|
Thanks @HeroicEric. You rock! |
bmac
added a commit
that referenced
this pull request
Feb 12, 2016
[BUGFIX beta] Allow optional spaces when parsing response headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4122
parseResponseHeadersfunction out ofDS.RestAdapterto its own moduleThe main reason for moving to a module was to make it easier to unit test in order to document current behavior before making the fix. Let me know if this is undesirable.