Log a deprecation warning when when Ember Data is loaded with Ember 1.13 #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Ember.deprecate(`Use of Ember Data 2+ with Ember 1.13 is deprecated. Please upgrade your version of Ember to 2.0 or higher.`, false, { | ||
| id: 'ds.version.ember-1-13', | ||
| until: '3.0.0' | ||
| }); | ||
| } | ||
|
|
||
| if (Ember.VERSION.match(/^1\.12\.0/)) { |
There was a problem hiding this comment.
I think this could be removed since we're erroring out < 1.13 anyway?
ddb7de3 to
86501a0
Compare
| if (Ember.VERSION.match(/^1\.13\./)) { | ||
| Ember.deprecate(`Use of Ember Data 2+ with Ember 1.13 is deprecated. Please upgrade your version of Ember to 2.0 or higher.`, false, { | ||
| id: 'ds.version.ember-1-13', | ||
| until: '3.0.0' |
There was a problem hiding this comment.
I think this means we are telling people that we are supporting 1.13 ember until ember data 3.0. I don't know how achievable this goal really is.
There was a problem hiding this comment.
Thanks for pointing this out @fivetanley. I'm not sure what to put for this value. Any thoughts @igorT? @wycats?
There was a problem hiding this comment.
We chatted about this in the weekly meeting and decided we should add a warning for now and will likely choose the first LTS release as the version where we drop 1.13 support for good.
281d97b to
14a2a8a
Compare
14a2a8a to
8635f50
Compare
bmac
added a commit
that referenced
this pull request
Dec 4, 2015
Log a deprecation warning when when Ember Data is loaded with Ember 1.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.