Improve test coverage for store#findRecord() #3746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@irnc am I misunderstanding the bug you were running into? |
| }); | ||
| }); | ||
|
|
||
| test("store#findRecord { reload: true } ignores cached record and reloads record from server", function() { |
There was a problem hiding this comment.
@HeroicEric in this test could you also assert that shouldReloadRecord is never called when { reload: true } is passed into findRecord?
There was a problem hiding this comment.
|
Thanks @HeroicEric this looks great! |
b337f57 to
0bef520
Compare
|
Thanks @HeroicEric |
bmac
added a commit
that referenced
this pull request
Sep 10, 2015
…-record Improve test coverage for store#findRecord()
|
@HeroicEric Tests look good. I should have misread code, so my report is incorrect, based on how I read it right now. But there is definitely an issue for my app, which I can reproduce, but can not debug it right now because Chrome does not stop on breakpoint in |
|
@irnc try disabling sourcemaps in your chrome dev tools.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started working on fixing #3704 by trying to write a failing test but was not able to reproduce the issue.
Am I missing something?