Add ember-cli-dependency-checker. #3636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are using ember-cli to build ember-data we can take advantage of the work done in ember-cli-dependency-checker to ensure that the deps in `node_modules` and `bower_components` actually match what is specified in the `package.json`/`bower.json`. With this added, running `ember` commands will error if matching versions are not found.
|
👍 just waiting on travis to make sure it likes it. |
|
Build failure is not the fault of this commit. Merging. We have some work to do to fix on canary. |
fivetanley
added a commit
that referenced
this pull request
Aug 10, 2015
Add ember-cli-dependency-checker.
|
👍 |
|
Thanks @rwjblue |
|
@fivetanley FYI this appears to have been red when merged. And is blocking other PR now, going forward can I recommend we avoid this? FYI: im digging into the failure right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are using ember-cli to build ember-data we can take advantage of the work done in ember-cli-dependency-checker to ensure that the deps in
node_modulesandbower_componentsactually match what is specified in thepackage.json/bower.json.With this added, running
embercommands will error if matching versions are not found.This will help prevent issues like #3635 in the future.