Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename error attribute #3534

Merged
merged 2 commits into from
Jul 17, 2015
Merged

Rename error attribute #3534

merged 2 commits into from
Jul 17, 2015

Conversation

tchak
Copy link
Member

@tchak tchak commented Jul 12, 2015

@bmac
Copy link
Member

bmac commented Jul 13, 2015

Code looks good to me. Do we need to define a deprecation for the old error property?

@bmac
Copy link
Member

bmac commented Jul 13, 2015

Also @tchak do you mind prefacing the commits with [BUGFIX release] so we can make sure to cherry-pick the commits over to the 1.13 branch?

@tchak tchak force-pushed the rename-error-attribute branch from 99d5198 to 687fc9f Compare July 14, 2015 15:59
@tchak
Copy link
Member Author

tchak commented Jul 14, 2015

@bmac renaming is done

bmac added a commit that referenced this pull request Jul 17, 2015
@bmac
Merge pull request #3534 from tchak/rename-error-attribute
1bea9b7 
Rename error attribute
@bmac bmac merged commit 1bea9b7 into emberjs:master Jul 17, 2015
@bmac
Copy link
Member

bmac commented Jul 17, 2015

Thanks @tchak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchak @bmac