Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix release] Remove some usages of enumerable utils that made it … #3411

Merged
merged 1 commit into from
Jun 22, 2015
Merged

[Bugfix release] Remove some usages of enumerable utils that made it … #3411

merged 1 commit into from
Jun 22, 2015

Conversation

bmac
Copy link
Member

@bmac bmac commented Jun 22, 2015

…into the release branch

@stefanpenner
Copy link
Member

Are these also addresses in master? Basically are they using the native es5 in master?

@bmac
Copy link
Member Author

bmac commented Jun 22, 2015

Yes these are already using native es5 methods on master.

https://github.com/emberjs/data/blob/master/packages/activemodel-adapter/lib/system/active-model-serializer.js#L279

https://github.com/emberjs/data/blob/master/packages/ember-data/lib/serializers/json-api-serializer.js#L39

@stefanpenner
Copy link
Member

Perfect. Just wanted to make sure I didn't miss them

wecc added a commit that referenced this pull request Jun 22, 2015
@wecc
Merge pull request #3411 from bmac/enumerable-utils
08c8852 
[Bugfix release] Remove some usages of enumerable utils that made it …
@wecc wecc merged commit 08c8852 into emberjs:release Jun 22, 2015
@wecc
Copy link
Contributor

wecc commented Jun 22, 2015

👍

@bmac bmac deleted the enumerable-utils branch June 22, 2015 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmac @stefanpenner @wecc