-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate store.pushMany in favor of store.push #3326
Conversation
LGTM, not sure why Travis fails. |
Seems to die on canary. To debug this locally, you can use |
@fivetanley - thanks for the tip, although it's all green on my local machine. I tried running Any ideas? |
Probably phantomJS related :( PhantomJS lacks some ES5 APIs out of the box. Are you on OSX? |
I am on OSX in fact, but I have a Windows VM handy... anything I can do to replicate the error and solve it? |
The reason I ask about OSX is that it's currently the easiest platform to try out phantomjs 2 on. If you run That will at least let us know if it's a PhantomJS 1.9 issue and/or a PhantomJS 2.0 issue. |
I had a fully green test suite before I upgraded, and then following your steps I still have a fully green test suite. edit: seems like I had phantomjs installed through npm globally. Let me retry |
@mikehollis sorry to lead you on a goose chase, seems to be a blip on the phantomjs build. Travis is passing again. |
Thanks! 🎉 |
Deprecate store.pushMany in favor of store.push
No worries @fivetanley -- I learned some things just by going through that 👍 |
This fixes #3246
Deprecates store.pushMany in favor of store.push