Snapshots unknown relationships #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| setHasData: function(value) { | ||
| var inverseKey = this.inverseKey; | ||
| if (inverseKey) { | ||
| this.canonicalMembers.forEach(function(member) { |
There was a problem hiding this comment.
This breaks if your inverse is a many relationship, because even though you only added one record, you are saying it has all of them. Not really sure what to do about this though. Also this seems like the wrong place, probably should happen automatically as the setHasData gets called by addCanonicalRecord
There was a problem hiding this comment.
After consulting with @stefanpenner we think it's ok to just send what we have
72b009a to
775b8a2
Compare
| }, | ||
|
|
||
| notifyRecordRelationshipAdded: Ember.K, | ||
| notifyRecordRelationshipRemoved: Ember.K, | ||
|
|
||
| setHasData: function() { | ||
| setHasData: function(value) { | ||
| this.hasData = true; |
There was a problem hiding this comment.
seems like we should do this.hasData = value instead
775b8a2 to
94dfd68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of solving the problem described in #2936.
Snapshots are now aware of unknown relationships and can return
undefinedfrombelongsTo()andhasMany()if that is the case.Ping @igorT re: f67ab9c