Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs sample error: recordRef push param must be with type #5808

Closed
yaxinr opened this issue Dec 26, 2018 · 2 comments
Closed

docs sample error: recordRef push param must be with type #5808

yaxinr opened this issue Dec 26, 2018 · 2 comments
Labels
🏷️ bug This PR primarily fixes a reported issue 🏷️ doc This PR adds/improves/or fixes documentation

Comments

@yaxinr
Copy link

yaxinr commented Dec 26, 2018

userRef.push({ data: { id: 1, MUST PRESENT->type: 'user', username: "@user" }}).then(function(user) {
userRef.value() === user;
});

@runspired
Copy link
Contributor

I believe what we want here in the docs is

userRef.push({
  data: {
    id: "1",
    type: "user",
    attributes: { username: "@user" }
 }
});

rajasegar pushed a commit to rajasegar/data that referenced this issue Mar 4, 2019
Fixes emberjs#5808
Added type to push data with value "user"
@rajasegar
Copy link
Contributor

@runspired Raised a PR #5889 for the same, can you please verify the fix

runspired pushed a commit that referenced this issue Mar 5, 2019
Fixes #5808
Added type to push data with value "user"
@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue 🏷️ doc This PR adds/improves/or fixes documentation and removed Bug labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bug This PR primarily fixes a reported issue 🏷️ doc This PR adds/improves/or fixes documentation
Projects
None yet
Development

No branches or pull requests

3 participants