Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generateIdForRecord api doc #5803

Closed
yaxinr opened this issue Dec 21, 2018 · 2 comments
Closed

generateIdForRecord api doc #5803

yaxinr opened this issue Dec 21, 2018 · 2 comments
Labels
🏷️ bug This PR primarily fixes a reported issue 🏷️ doc This PR adds/improves/or fixes documentation

Comments

@yaxinr
Copy link

yaxinr commented Dec 21, 2018

/**

wrong: generateIdForRecord(store, inputProperties)
must be: generateIdForRecord(store, type, inputProperties)

@runspired
Copy link
Contributor

Thanks for pointing out the mistake in the docs!

rajasegar added a commit to rajasegar/data that referenced this issue Mar 4, 2019
Fixes emberjs#5803
Missing type param in generateIdForRecord api doc
@rajasegar
Copy link
Contributor

@runspired Raised a PR #5892 , kindly verify

runspired pushed a commit that referenced this issue Mar 4, 2019
Fixes #5803
Missing type param in generateIdForRecord api doc
@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue 🏷️ doc This PR adds/improves/or fixes documentation and removed Bug labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bug This PR primarily fixes a reported issue 🏷️ doc This PR adds/improves/or fixes documentation
Projects
None yet
Development

No branches or pull requests

3 participants