Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If ember-cli-shims is not >= 0.1.0, this should cause the build to fail. #4044

Closed
fivetanley opened this issue Jan 5, 2016 · 0 comments · Fixed by #4057
Closed

If ember-cli-shims is not >= 0.1.0, this should cause the build to fail. #4044

fivetanley opened this issue Jan 5, 2016 · 0 comments · Fixed by #4057

Comments

@fivetanley
Copy link
Member

I see people are already hitting this a lot by trying out the betas and missing it in any various log outputs. This should probably exit the build with an error code if it doesn't produce a working build.

https://github.com/emberjs/data/blob/master/index.js#L38
fivetanley pushed a commit to fivetanley/data that referenced this issue Jan 11, 2016
[BUGFIX beta] fail builds in ember-cli when ember-cli-shims isn't met
e0efa2d 
fixes emberjs#4044
@fivetanley fivetanley mentioned this issue Jan 11, 2016
Merged
fivetanley pushed a commit to fivetanley/data that referenced this issue Jan 12, 2016
[BUGFIX beta] fail builds in ember-cli when ember-cli-shims isn't met
d4e24bb 
fixes emberjs#4044
fivetanley pushed a commit to fivetanley/data that referenced this issue Jan 12, 2016
[BUGFIX beta] fail builds in ember-cli when ember-cli-shims isn't met
dd3f3c6 
fixes emberjs#4044
fivetanley pushed a commit to fivetanley/data that referenced this issue Jan 12, 2016
[BUGFIX beta] fail builds in ember-cli when ember-cli-shims isn't met
3454fe5 
fixes emberjs#4044
bmac pushed a commit that referenced this issue Jan 12, 2016
@bmac
[BUGFIX beta] fail builds in ember-cli when ember-cli-shims isn't met
ef48cfd 
fixes #4044

(cherry picked from commit 3454fe5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX beta] fail builds in ember-cli when ember-cli-shims isn't met fivetanley/data
1 participant
@fivetanley